Project

General

Profile

Actions

Defect #33140

closed

Gantt bar is not displayed if the due date is the leftmost date or the start date is the rightmost date

Added by Jaebok Oh almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Gantt
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If the start date and due date are 1st of the month, this will not be displayed.


Files

gantchart.png (144 KB) gantchart.png Jaebok Oh, 2020-03-13 03:16
33140.patch (2.46 KB) 33140.patch Yuichi HARADA, 2020-03-16 07:07

Related issues

Related to Redmine - Defect #33175: Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the ganttClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA almost 5 years ago

  • Status changed from New to Confirmed
  • Affected version changed from 4.1.0 to 4.0.6
Actions #2

Updated by Go MAEDA almost 5 years ago

  • Subject changed from If the start date and due date are 1st of the month, this will not be displayed. to Gantt bar is not displayed if the start date and the due date are the first day of the month
Actions #3

Updated by Go MAEDA almost 5 years ago

  • Subject changed from Gantt bar is not displayed if the start date and the due date are the first day of the month to Gantt bar is not displayed if the due date is the first day of the month
Actions #4

Updated by Yuichi HARADA almost 5 years ago

With the following patch, the Gantt bar is displayed if the due date is the first day of the Gantt or the start date is the last day of the Gantt.

diff --git a/lib/redmine/helpers/gantt.rb b/lib/redmine/helpers/gantt.rb
index 285eb66a0..e4663e08e 100644
--- a/lib/redmine/helpers/gantt.rb
+++ b/lib/redmine/helpers/gantt.rb
@@ -623,7 +623,7 @@ module Redmine
       def coordinates(start_date, end_date, progress, zoom=nil)
         zoom ||= @zoom
         coords = {}
-        if start_date && end_date && start_date < self.date_to && end_date > self.date_from
+        if start_date && end_date && start_date <= self.date_to && end_date >= self.date_from
           if start_date > self.date_from
             coords[:start] = start_date - self.date_from
             coords[:bar_start] = start_date - self.date_from
Actions #5

Updated by Go MAEDA over 4 years ago

  • Target version set to Candidate for next minor release
Actions #6

Updated by Go MAEDA over 4 years ago

  • Target version changed from Candidate for next minor release to 4.0.8

Setting the target version to 4.0.8.

Actions #7

Updated by Go MAEDA over 4 years ago

  • Subject changed from Gantt bar is not displayed if the due date is the first day of the month to Gantt bar is not displayed if the due date is the leftmost date or the start date is the rightmost date
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Actions #8

Updated by Go MAEDA over 4 years ago

  • Status changed from Resolved to Closed
Actions #9

Updated by Go MAEDA over 4 years ago

  • Related to Defect #33175: Starting or ending marker is not displayed if they are on the leftmost or rightmost boundary of the gantt added
Actions

Also available in: Atom PDF