Project

General

Profile

Actions
Copy link

Defect #33206

closed

Unable to autoload constant Version.table_name if gems uses Version class

Added by Alexander Meindl over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Gems support
Target version:
4.1.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Introduced with r18780 Version.table_name is not available, if a gem package (like attr_encrypted) is used with a class named "Version".

At the moment this problem does not exist with Gem packages from Redmine itself, but gems from plugins.

Existing tests are broken, e.g.

bin/rails test test/unit/project_test.rb -n test_move_a_root_project_to_a_project
# Running:

E

Error:
ProjectTest#test_move_a_root_project_to_a_project:
NoMethodError: undefined method `table_name' for AttrEncrypted::Version:Module
    app/models/issue.rb:1739:in `update_versions'
    app/models/issue.rb:1385:in `update_versions_from_hierarchy_change'
    app/models/project.rb:935:in `update_versions_from_hierarchy_change'
    app/models/project.rb:424:in `set_parent!'
    test/unit/project_test.rb:316:in `test_move_a_root_project_to_a_project'

Similar problem was #23269. A better description of the problem with examples are here: https://stackoverflow.com/questions/21115567/autoloading-classes-using-class-self-in-rails

I added a patch for a more solid solution to prevent the problem. It would be great to have this change in Redmine.

Files

Download all files
full_qualified_version_class.patch (858 Bytes) full_qualified_version_class.patch Alexander Meindl, 2020-03-29 08:54
full_qualified_version_class_version2.patch (1.46 KB) full_qualified_version_class_version2.patch Alexander Meindl, 2020-03-29 09:33
Actions
Copy link
 #1

Updated by Alexander Meindl over 4 years ago

I added another version of patch, which uses Rails 5 where.not and Arel::Table. With this solution, no more table name specification is required.

Both solutions work, but second one is more cleaner - but more refactoring.

Actions
Copy link
 #2

Updated by Go MAEDA almost 4 years ago

  • Tracker changed from Patch to Defect
  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release

Steps to reproduce the issue:

echo gem \'attr_encrypted\' >> Gemfile.local
bundle install
bin/rails test test/unit/project_test.rb -n test_move_a_root_project_to_a_project

Actions
Copy link
 #3

Updated by Pavel Rosický almost 4 years ago

I think the first variant should be preferred, see https://github.com/rails/rails/issues/36761

Actions
Copy link
 #4

Updated by Go MAEDA almost 4 years ago

  • Target version changed from Candidate for next minor release to 4.0.8

I will commit the former patch, full_qualified_version_class.patch soon.

Actions
Copy link
 #5

Updated by Go MAEDA almost 4 years ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for reporting and fixing the issue.

Actions
Copy link
 #6

Updated by Go MAEDA almost 4 years ago

  • Status changed from Resolved to Closed
  • Target version changed from 4.0.8 to 4.1.2
Actions
Copy link

Also available in: Atom PDF