Project

General

Profile

Actions

Feature #33256

closed

Show wiki toolbar for spent time custom fields with text formatting enabled

Added by Marius BĂLTEANU over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Time tracking
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Before:

Using this patch:


Files

after.png (147 KB) after.png Marius BĂLTEANU, 2020-04-05 11:44
before.png (120 KB) before.png Marius BĂLTEANU, 2020-04-05 11:44
0001-Show-wiki-toolbar-in-time-spent-form-for-custom-fiel.patch (2.15 KB) 0001-Show-wiki-toolbar-in-time-spent-form-for-custom-fiel.patch Marius BĂLTEANU, 2020-04-05 11:50
33256-undefined-in-preview.png (81.1 KB) 33256-undefined-in-preview.png Go MAEDA, 2020-04-05 16:05

Related issues

Has duplicate Redmine - Feature #33288: Add wiki bar to Time_LogClosed

Actions
Blocked by Redmine - Defect #32471: Layout of the custom field edit page is different between the single edit page and the batch edit pageClosedGo MAEDA

Actions
Actions #1

Updated by Marius BĂLTEANU over 4 years ago

This patch implements the wiki toolbar in the following pages:
  1. timelog#new
  2. timelog#edit
  3. timelog#bulk_edit.
Actions #2

Updated by Marius BĂLTEANU over 4 years ago

Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/132973534 (the one that fails is caused by another issue).

Actions #3

Updated by Go MAEDA over 4 years ago

Thank you for submitting the patch, but I found an issue that the Preview tab always displays "undefined" when bulk editing time entries. See 33256-undefined-in-preview.png.

Actions #4

Updated by Marius BĂLTEANU over 4 years ago

Go MAEDA wrote:

Thank you for submitting the patch, but I found an issue that the Preview tab always displays "undefined" when bulk editing time entries. See 33256-undefined-in-preview.png.

Oh, I forgot to mention that it should work on top of #32471. Can you retest it after you apply those patches?

Actions #5

Updated by Go MAEDA over 4 years ago

  • Blocked by Defect #32471: Layout of the custom field edit page is different between the single edit page and the batch edit page added
Actions #6

Updated by Go MAEDA over 4 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you.

Actions #7

Updated by Go MAEDA over 4 years ago

Actions

Also available in: Atom PDF