Project

General

Profile

Actions

Defect #33273

closed

Total estimated time column shows up as decimal value regardless of time setting

Added by Farook Al-Sammarraie about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues list
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

the reason for the issue is that total_estimated_hours is missing from queries_helper.rb

the issue can be fixed by changing lines 170 and 241:

diff --git a/app/helpers/queries_helper.rb b/app/helpers/queries_helper.rb
index 2e5b86b6e..a9d8cff6f 100644
--- a/app/helpers/queries_helper.rb
+++ b/app/helpers/queries_helper.rb
@@ -167,7 +167,7 @@ module QueriesHelper
   def total_tag(column, value)
     label = content_tag('span', "#{column.caption}:")
     value =
-      if [:hours, :spent_hours, :total_spent_hours, :estimated_hours].include? column.name
+      if [:hours, :spent_hours, :total_spent_hours, :estimated_hours, :total_estimated_hours].include? column.name
         format_hours(value)
       else
         format_object(value)
@@ -238,7 +238,7 @@ module QueriesHelper
         'span',
         value.to_s(item) {|other| link_to_issue(other, :subject => false, :tracker => false)}.html_safe,
         :class => value.css_classes_for(item))
-    when :hours, :estimated_hours
+    when :hours, :estimated_hours, :total_estimated_hours
       format_hours(value)
     when :spent_hours
       link_to_if(value > 0, format_hours(value), project_time_entries_path(item.project, :issue_id => "#{item.id}"))

(I already fixed it on my instance)

I'm not exactly sure if subversion supports something like pull requests in git, so i'm opening an issue instead


Files

33273-test.patch (1.05 KB) 33273-test.patch Go MAEDA, 2020-04-12 04:52
33273_4.0.8.patch (2.64 KB) 33273_4.0.8.patch Marius BĂLTEANU, 2020-04-16 18:04

Related issues

Related to Redmine - Feature #23996: Introduce a setting to change the display format of timespans to HH:MMClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #20688: Add Total estimated hours column on issue list ClosedJean-Philippe Lang

Actions
Has duplicate Redmine - Defect #34775: Total time estimate isn't in the right formatClosed

Actions
Actions #1

Updated by Go MAEDA about 4 years ago

  • Related to Feature #23996: Introduce a setting to change the display format of timespans to HH:MM added
Actions #2

Updated by Go MAEDA about 4 years ago

  • Related to Feature #20688: Add Total estimated hours column on issue list added
Actions #3

Updated by Go MAEDA about 4 years ago

  • Description updated (diff)
  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release
Actions #4

Updated by Go MAEDA about 4 years ago

Here is a test for the patch.

Setting the target version to 4.1.2.

Actions #5

Updated by Marius BĂLTEANU about 4 years ago

  • Subject changed from total esitmated time column shows up as decimal value regardless of time setting to Total estimated time column shows up as decimal value regardless of time setting
Actions #6

Updated by Go MAEDA about 4 years ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your report and fix.

Actions #7

Updated by Marius BĂLTEANU about 4 years ago

Go MAEDA wrote:

Committed the patch. Thank you for your report and fix.

Go Maeda, is there any reason for why we don't merge this to 4.0.8 as well?

Actions #8

Updated by Go MAEDA about 4 years ago

Marius BALTEANU wrote:

Go Maeda, is there any reason for why we don't merge this to 4.0.8 as well?

This is because I simply didn't want to do manual work. r19702 cannot be auto-merged to 4.0-stable. But I will do it if you or someone think that the fix should be a part of 4.0.8.

Actions #9

Updated by Marius BĂLTEANU about 4 years ago

Attached the patch to back port to 4.0.8 as well.

Actions #10

Updated by Go MAEDA almost 4 years ago

Marius BALTEANU wrote:

Attached the patch to back port to 4.0.8 as well.

Thank you for the patch but the test fails.

Failure:
IssuesControllerTest#test_index_should_respect_timespan_format [test/functional/issues_controller_test.rb:1607]:
<200:00> expected but was
<>..
Expected 0 to be >= 1.

bin/rails test test/functional/issues_controller_test.rb:1598
Actions #11

Updated by Marius BĂLTEANU almost 4 years ago

  • Status changed from Reopened to Closed
  • Target version changed from 4.0.8 to 4.1.2

Sorry for not running the tests.

Actions #12

Updated by Go MAEDA about 3 years ago

  • Has duplicate Defect #34775: Total time estimate isn't in the right format added
Actions

Also available in: Atom PDF