Feature #33383

Update jQuery to 3.5.1

Added by Marius BALTEANU 29 days ago. Updated 7 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Code cleanup/refactoring
Target version:Candidate for next major release
Resolution:

Description

jQuery 2 is end of life and we should update the code to support latest jQuery 3.5.0 (at this time).

0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch Magnifier (1016 Bytes) Marius BALTEANU, 2020-05-20 23:04

0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch Magnifier (183 KB) Marius BALTEANU, 2020-05-20 23:04


Related issues

Related to Redmine - Patch #33384: jQuery: replace deprecated size() method with length Closed
Related to Redmine - Defect #33392: Fix invalid selector in function displayTabsButtons() Closed

History

#1 Updated by Marius BALTEANU 29 days ago

  • Related to Patch #33384: jQuery: replace deprecated size() method with length added

#2 Updated by Marius BALTEANU 28 days ago

  • Related to Defect #33392: Fix invalid selector in function displayTabsButtons() added

#3 Updated by Marius BALTEANU 10 days ago

Here are two patches that update jQuery to 3.5.1 and fix a problem caused by this change.

Because the update can break some plugins, I propose the following plan for this update:
  1. Commit the current patches
  2. Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
  3. After this period, commit jQuery Migrate
  4. In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.

#4 Updated by Go MAEDA 7 days ago

Thank you for working on updating JQuery.

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:
  1. Commit the current patches
  2. Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
  3. After this period, commit jQuery Migrate

I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.

Do you think it is OK to commit the patches right now?

Also available in: Atom PDF