Feature #33383: Update jQuery to 3.5.1 - Redmine

Actions

Copy link

Feature #33383

closed

Update jQuery to 3.5.1

Added by Marius BĂLTEANU almost 4 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Third-party libraries

Target version:

4.2.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Description

jQuery 2 is end of life and we should update the code to support latest jQuery 3.5.0 (at this time).

Files

Download all files

0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch (1016 Bytes) 0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch		Marius BĂLTEANU, 2020-05-20 23:04
0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch (183 KB) 0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch		Marius BĂLTEANU, 2020-05-20 23:04
add-jquery-migrate.patch (11.7 KB) add-jquery-migrate.patch		Go MAEDA, 2020-11-29 06:52
remove_security_fix_for_jquery_1_2.patch (585 Bytes) remove_security_fix_for_jquery_1_2.patch		Marius BĂLTEANU, 2021-01-09 12:59

Related issues

Actions

Copy link

Updated by Marius BĂLTEANU almost 4 years ago

Related to Patch #33384: jQuery: replace deprecated size() method with length added

Actions

Copy link

Updated by Marius BĂLTEANU almost 4 years ago

Related to Defect #33392: Fix invalid selector in function displayTabsButtons() added

Actions

Copy link

Updated by Marius BĂLTEANU almost 4 years ago

File 0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch 0002-Fix-cannot-set-property-dragover-of-undefined-jQuery.patch added
File 0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch 0001-Update-jQuery-to-3.5.1-without-jQuery-Migrate.patch added
Subject changed from Update jQuery to 3.5.0 to Update jQuery to 3.5.1
Assignee deleted (~~Marius BĂLTEANU~~)

Here are two patches that update jQuery to 3.5.1 and fix a problem caused by this change.

Because the update can break some plugins, I propose the following plan for this update:

Commit the current patches
Keep this ticket open for one or two months in order to have time to find potential problems generated by the update
After this period, commit jQuery Migrate
In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.

Actions

Copy link

Updated by Go MAEDA almost 4 years ago

Thank you for working on updating JQuery.

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:

Commit the current patches

Keep this ticket open for one or two months in order to have time to find potential problems generated by the update

After this period, commit jQuery Migrate

I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.

Do you think it is OK to commit the patches right now?

Actions

Copy link

Updated by Go MAEDA almost 4 years ago

Target version changed from Candidate for next major release to 4.2.0

I think it is better to commit this patch as soon as possible in order to detect problems early. Setting the target version to 4.2.0.

Actions

Copy link

Updated by Go MAEDA almost 4 years ago

Status changed from New to Resolved
Assignee set to Go MAEDA
Resolution set to Fixed

Committed the patches. Thank you.

Actions

Copy link

Updated by Marius BĂLTEANU almost 4 years ago

Go MAEDA wrote:

Thank you for working on updating JQuery.

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:

Commit the current patches

Keep this ticket open for one or two months in order to have time to find potential problems generated by the update

After this period, commit jQuery Migrate

I agree. In order to make enough time to discover and fix issues caused by the update, I think it is better to commit the patches as soon as we can.

Do you think it is OK to commit the patches right now?

Sorry for my late reply, yes, it's ok to have the patches committed.

Actions

Copy link

Updated by Go MAEDA over 3 years ago

Related to Defect #33896: Incorrect position of the revision graph added

Actions

Copy link

Updated by Go MAEDA over 3 years ago

File add-jquery-migrate.patch add-jquery-migrate.patch added
Assignee changed from Go MAEDA to Marius BĂLTEANU

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:

Commit the current patches

Keep this ticket open for one or two months in order to have time to find potential problems generated by the update

After this period, commit jQuery Migrate

In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.

Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?

Actions

Copy link

#10

Updated by Marius BĂLTEANU over 3 years ago

Go MAEDA wrote:

Marius BALTEANU wrote:

Because the update can break some plugins, I propose the following plan for this update:

Commit the current patches

Keep this ticket open for one or two months in order to have time to find potential problems generated by the update

After this period, commit jQuery Migrate

In Redmine 5.0.0, remove jQuery Migrate and keep only the latest jQuery version.

Six months have passed since upgrading JQuery to 3.5.1. I think it is time to add jquery-migrate. Marius, what is your opinion?

Yes, let's do it.

Actions

Copy link

#11