Project

General

Profile

Actions
Copy link

Feature #33425

open

Auto complete wiki macros

Added by Go MAEDA over 4 years ago. Updated about 4 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
Candidate for next major release
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

The attached patch adds an auto-complete feature for wiki macros. The patch can be applied after updating Tribute with the patch #33424.

The macros are useful, however, those are a bit long to type by hand. And it is also hard for some people to remember. I think these inconveniences can be eliminated by supporting auto-complete for wiki macros.

Files

Download all files
macro-auto-complete.png (26.2 KB) macro-auto-complete.png Go MAEDA, 2020-05-10 09:09
33425.patch (2.47 KB) 33425.patch Go MAEDA, 2020-05-11 04:23
33425-v2.patch (1.85 KB) 33425-v2.patch Mizuki ISHIKAWA, 2020-06-10 07:50
33425_v3.patch (3.12 KB) 33425_v3.patch Mizuki ISHIKAWA, 2020-08-05 06:38
33425_v4.patch (2.73 KB) 33425_v4.patch Marius BĂLTEANU, 2020-10-12 00:10

Related issues

Related to Redmine - Feature #30986: New toolbar button to insert wiki macrosNew

Actions
Related to Redmine - Feature #33820: Auto complete wiki page linksClosedGo MAEDA

Actions
Related to Redmine - Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabledClosedGo MAEDA

Actions
Blocked by Redmine - Patch #33424: Update Tribute to 5.1.3ClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 4 years ago

Actions
Copy link
 #2

Updated by Go MAEDA over 4 years ago

  • Related to Feature #30986: New toolbar button to insert wiki macros added
Actions
Copy link
 #3

Updated by Go MAEDA over 4 years ago

Sorry, I forgot to attach a patch.

Actions
Copy link
 #4

Updated by Go MAEDA over 4 years ago

  • Target version set to Candidate for next major release
Actions
Copy link
 #5

Updated by Go MAEDA over 4 years ago

  • Target version changed from Candidate for next major release to 4.2.0

Let's include this feature in 4.2.0.

Actions
Copy link
 #6

Updated by Mizuki ISHIKAWA over 4 years ago

I Fixed so that macro completion does not work in the search form in the upper right.

Actions
Copy link
 #7

Updated by Marius BĂLTEANU over 4 years ago

  • Assignee set to Marius BĂLTEANU
Actions
Copy link
 #8

Updated by Mizuki ISHIKAWA over 4 years ago

With 33425_v2.patch, there was a problem that tribute would be re-initialized even if it was already initialized.
Fix to initialize only when `element.dataset.tribute != 'true'`.

Actions
Copy link
 #9

Updated by Marius BĂLTEANU about 4 years ago

  • File 33425_v4.patch 33425_v4.patch added
  • Assignee deleted (Marius BĂLTEANU)
  • Target version changed from 4.2.0 to Candidate for next major release

We should use collection to add a new trigger, please see an example attached.

The patch is still not ready because the concern raised by Bernhard and Jean-Philippe in #30986#note-7 is still available and I agree with them, we need a method to describe the macros and how to use them.

Actions
Copy link
 #10

Updated by Marius BĂLTEANU about 4 years ago

Another limitation of the patch in the current state is the hardcoded macros values which makes very hard for plugin developers that add new macros to add them to the auto complete as well.

Actions
Copy link
 #11

Updated by Marius BĂLTEANU about 4 years ago

Actions
Copy link
 #12

Updated by Marius BĂLTEANU about 4 years ago

  • Related to Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled added
Actions
Copy link

Also available in: Atom PDF