Project

General

Profile

Actions

Defect #33576

closed

Done ratio of a parent issue may be shown as 99% even though all subtasks are completed

Added by Go MAEDA over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Due to a rounding error at source:tags/4.1.1/app/models/issue.rb#L1717, a parent task may show 99% done even when all subtasks are 100% done.

irb(main):001:0> 1610 / 16.1
=> 99.99999999999999

Steps to reproduce:

1. Set "% Done" setting (Administration > Settings > Issue tracking) to "Calculated from subtasks"
2. Create a parent task.
3. Create a subtask 1 with 10.0 estimated hours and 100% done ratio
4. Create a subtask 2 with 6.1 estimated hours and 100% done ratio
5. Now the done ratio of the parent task shows 99% instead of 100%


Files

clipboard-202006101529-abpb8.png (53.4 KB) clipboard-202006101529-abpb8.png Go MAEDA, 2020-06-10 08:47
fix-33576.patch (1.4 KB) fix-33576.patch Go MAEDA, 2020-06-10 10:18
fix-33576-v2.patch (1.94 KB) fix-33576-v2.patch Go MAEDA, 2020-06-10 11:33

Related issues

Related to Redmine - Defect #27848: The progress exceeding 99.5% is displayed as 100%ClosedJean-Philippe Lang

Actions
Related to Redmine - Defect #37151: The done ratio of a parent issue may not be 100% even if all subtasks have a done ratio of 100%ClosedGo MAEDA

Actions
Actions

Also available in: Atom PDF