Project

General

Profile

Actions

Defect #33829

open

Tags "updated" in issues atom are "created on"

Added by Tatsuya Saito almost 3 years ago. Updated over 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Feeds
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

There are updated tags in the Atom of issues list.
However, the created on is exported.

I have attached a patch to fix this.


Files

patch.diff (759 Bytes) patch.diff Tatsuya Saito, 2020-08-08 09:34
patch_trunk_r19958_pt1.diff (2.64 KB) patch_trunk_r19958_pt1.diff note-3 patch pattern 1 Tatsuya Saito, 2020-08-08 17:26
patch_trunk_r19958_pt2.diff (924 Bytes) patch_trunk_r19958_pt2.diff note-3 patch pattern 2 Tatsuya Saito, 2020-08-08 17:26
Actions #1

Updated by Tatsuya Saito almost 3 years ago

This issue is reported in following Japanese forum.
https://groups.google.com/forum/#!topic/redmine-users-ja/wb78I8uVJEY

Actions #2

Updated by Tatsuya Saito almost 3 years ago

I'm sorry, patch.diff breaks Redmine rake test.
It breaks activity view items.
Please reject the patch.

Actions #3

Updated by Tatsuya Saito almost 3 years ago

I think this problem only affects the atom of issues list.
There are updated tags created by issue.event_datetime.
But issue.event_datetime is created_on.
I think you need to use updated_on for the atom of issue list.

I re-create the patches for this issue.
In the first pattern, issue_controller overwrites issue.event_datetime between atom exports.
The second pattern, application_controller.rb and common/feed.atom.builder, adds the code for the problem list atom.

Both work, but I don't think it's clean code.
I'll attach both patches in the hope that it will help you think about better code.

Actions #4

Updated by Go MAEDA over 2 years ago

  • Category changed from Issues list to Feeds
Actions #5

Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next major release
Actions

Also available in: Atom PDF