Project

General

Profile

Actions

Patch #34122

closed

Store inline autocomplete data sources in a JS variable

Added by Marius BĂLTEANU over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When I've implemented first the inline autocomplete feature (4.1.0) I chose to store the autocomplete data source path in a data attribute (data-issue-url) of each textarea field that support this feature. The solution touched 9 views files (r18444).

Since then, new requests came to support inline autocomplete for other sources like macros or wiki pages (#33425, #33820) and if we keep the current solution, we need to touch again the same files and add two new attributes. On a long term, the solution doesn't seem very efficient.

My proposal is to change the current implement and store all the paths in a JS variable, attached an working version.

Any feedback on this is really appreciated.


Files

Actions #1

Updated by Go MAEDA over 3 years ago

+1
The change makes views clearner.

Actions #2

Updated by Go MAEDA over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions

Also available in: Atom PDF