Project

General

Profile

Actions

Patch #34169

closed

MessagesControllerTest#test_post_new randomly fails

Added by Mizuki ISHIKAWA over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

MessagesControllerTest # test_post_new test fails (trunk)

Failure:
MessagesControllerTest#test_post_new [/root/project/test/functional/messages_controller_test.rb:150]:
Expected: ["jsmith@somenet.foo"]
  Actual: ["dlopper@somenet.foo"]

bin/rails test test/functional/messages_controller_test.rb:121

There is no guarantee that the elements will be in the order of "first: author, second: member" in the array mails, so the test should be modified so that it does not depend on the order.


Files

fix_test_post_new.patch (732 Bytes) fix_test_post_new.patch Mizuki ISHIKAWA, 2020-10-26 07:39
Actions #1

Updated by Go MAEDA over 3 years ago

  • Subject changed from MessagesControllerTest#test_post_new fails to MessagesControllerTest#test_post_new randomly fails
  • Target version set to 4.2.0

Setting the target version to 4.2.0.

Actions #2

Updated by vzvu 3k6k over 3 years ago

LGTM and thanks for fixing. This test was very flaky on PostgreSQL and caused many false positive failures.

This fix will make development much easier.

Actions #3

Updated by Go MAEDA over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions

Also available in: Atom PDF