Patch #34218
closed
Increase size of value field in settings
0%
Description
Size of value is text field which is around ~64kb.
In some cases like using some of plugins, errors like this might arise:
Mysql2::Error: Data too long for column 'value' at row 1: UPDATE settings SET value = '---\nprojects:\n 45:\n helpdesk_answer_from:
This patch increases size of text field to larger format.
Files
Updated by Go MAEDA over 1 year ago
- Target version set to 6.0.0
Setting the target version to 6.0.0.
Updated by Go MAEDA over 1 year ago
Updated by Marius BĂLTEANU over 1 year ago
We are sure that it is a good ideea to increase the size on the column to such a big value for settings table that is very used? Maybe some plugin developers should store these kind of settings in their own table.
I would like to have more feedback on this before committing.
Updated by Go MAEDA about 1 year ago
Currently, both PostgreSQL and SQLite allow 1GB of text. 64 KB for MySQL is quite small compared to those, so I think the upper limit could be increased.
This difference may cause a problem that a plugin works with PostgreSQL and SQLite but does not work with MySQL.
Updated by Marius BĂLTEANU about 1 year ago
Go MAEDA wrote in #note-4:
Currently, both PostgreSQL and SQLite allow 1GB of text. 64 KB for MySQL is quite small compared to those, so I think the upper limit could be increased.
This difference may cause a problem that a plugin works with PostgreSQL and SQLite but does not work with MySQL.
I don't want to be against of this change, I just wanted to point my concern.
Updated by Marius BĂLTEANU 6 months ago
- Status changed from New to Resolved
- Assignee set to Marius BĂLTEANU
Patch committed, thanks!