Project

General

Profile

Actions
Copy link

Patch #34218

open

Increase size of value field in settings

Added by Aleksandar Pavic almost 4 years ago. Updated 9 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Database
Target version:
6.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Size of value is text field which is around ~64kb.

In some cases like using some of plugins, errors like this might arise:

Mysql2::Error: Data too long for column 'value' at row 1: UPDATE settings SET value = '---\nprojects:\n 45:\n helpdesk_answer_from:

This patch increases size of text field to larger format.

Files

Download all files
20201104111101_change_settings_value_limit.rb (270 Bytes) 20201104111101_change_settings_value_limit.rb Increases size of value to long text Aleksandar Pavic, 2020-11-03 11:21
20240130052001_change_settings_value_limit.rb (246 Bytes) 20240130052001_change_settings_value_limit.rb for r22665 Go MAEDA, 2024-01-30 06:25
Actions
Copy link
 #1

Updated by Go MAEDA 9 months ago

  • Target version set to 6.0.0

Setting the target version to 6.0.0.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU 9 months ago

We are sure that it is a good ideea to increase the size on the column to such a big value for settings table that is very used? Maybe some plugin developers should store these kind of settings in their own table.

I would like to have more feedback on this before committing.

Actions
Copy link
 #4

Updated by Go MAEDA 9 months ago

Currently, both PostgreSQL and SQLite allow 1GB of text. 64 KB for MySQL is quite small compared to those, so I think the upper limit could be increased.

This difference may cause a problem that a plugin works with PostgreSQL and SQLite but does not work with MySQL.

Actions
Copy link
 #5

Updated by Marius BĂLTEANU 9 months ago

Go MAEDA wrote in #note-4:

Currently, both PostgreSQL and SQLite allow 1GB of text. 64 KB for MySQL is quite small compared to those, so I think the upper limit could be increased.

This difference may cause a problem that a plugin works with PostgreSQL and SQLite but does not work with MySQL.

I don't want to be against of this change, I just wanted to point my concern.

Actions
Copy link

Also available in: Atom PDF