Patch #34595
Filter list of recent projects in the project jump box
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Projects | |||
| Target version: | 4.1.2 |
Description
The attached patch makes sure that only currently visible projects are included in the project jump box, removing archived projects and projects the user is not allowed to view anymore.
The patch should apply cleanly on current trunk.
0001-Only-show-currently-visible-projects-in-the-project-.patch 
(826 Bytes)
0003-Add-a-test-for-34595.patch
(1.13 KB)
0002-Fix-failing-tests.patch
(917 Bytes)
0001-Apply-patch-from-34595.patch
(760 Bytes)
Associated revisions
Only show currently visible projects in the project jump box (#34595).
Patch by Holger Just.
Reverts r20735
Only show currently visible projects in the project jump box (#34595).
Patch by Holger Just and Marius BALTEANU.
History
#1
Updated by Marius BALTEANU 3 months ago
- Target version set to 4.1.2
#3
Updated by Go MAEDA 3 months ago
- Assignee deleted (
Go MAEDA)
The patch lacks one dot after "visible". Here is an updated patch.
Index: lib/redmine/project_jump_box.rb
===================================================================
--- lib/redmine/project_jump_box.rb (リビジョン 20737)
+++ lib/redmine/project_jump_box.rb (作業コピー)
@@ -31,6 +31,7 @@
def recently_used_projects
project_ids = recently_used_project_ids
Project.where(id: project_ids).
+ visible.
index_by(&:id).
values_at(*project_ids). # sort according to stored order
compact
#4
Updated by Holger Just 3 months ago
Ah sorry :(
I extracted the patch from our internal Redmine version where we have other changes in this code area. Your updated patch should work.
#6
Updated by Marius BALTEANU about 1 month ago
- File 0003-Add-a-test-for-34595.patch added
- File 0002-Fix-failing-tests.patch added
- File 0001-Apply-patch-from-34595.patch added
- Assignee set to Go MAEDA
Some tests fail:
root@d7a989d3c810:/work# ruby test/unit/lib/redmine/project_jump_box_test.rb
Run options: --seed 4246
# Running:
F
Failure:
Redmine::ProjectJumpBoxTest#test_should_limit_recently_used_projects [test/unit/lib/redmine/project_jump_box_test.rb:60]:
Expected: 1
Actual: 0
bin/rails test test/unit/lib/redmine/project_jump_box_test.rb:53
.F
Failure:
Redmine::ProjectJumpBoxTest#test_should_record_recently_used_projects_order [test/unit/lib/redmine/project_jump_box_test.rb:70]:
Expected: 2
Actual: 1
bin/rails test test/unit/lib/redmine/project_jump_box_test.rb:63
...F
Failure:
Redmine::ProjectJumpBoxTest#test_should_update_recents_list [test/unit/lib/redmine/project_jump_box_test.rb:134]:
Expected: 2
Actual: 1
bin/rails test test/unit/lib/redmine/project_jump_box_test.rb:118
Finished in 0.402722s, 17.3817 runs/s, 64.5606 assertions/s.
7 runs, 26 assertions, 3 failures, 0 errors, 0 skips
The attached patches fix those failings tests and add a test to ensure that only visible projects are listed.
https://gitlab.com/redmine-org/redmine/-/pipelines/270899596
#7
Updated by Go MAEDA about 1 month ago
- Status changed from New to Closed
Committed the patch. Thank you.