Project

General

Profile

Actions
Copy link

Defect #34986

closed

Ruby 3.0 fix super calls

Added by Pavel Rosický over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Ruby support
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

https://github.com/rails/rails/blob/f855139f3d2bb9b032613279d0adfbd6a77a2d07/activerecord/lib/active_record/persistence.rb#L487

https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

there're failures on Ruby 3.0 due to kwargs separation, these two places should be changed either to accept kwargs instead of args or ignore them.

note that Ruby 3.0 isn't supported without Rails patches #29914

Files

ruby3.diff (863 Bytes) ruby3.diff Pavel Rosický, 2021-03-30 12:14

Related issues

Related to Redmine - Feature #34992: Ruby 3.0 supportClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 3 years ago

Actions
Copy link
 #2

Updated by Go MAEDA over 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch as a part of #34992. Thank you.

Actions
Copy link

Also available in: Atom PDF