Patch #35081

Update config/environments/*.rb for Rails 6.1

Added by Go MAEDA about 1 year ago. Updated 6 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Rails support
Target version:5.0.0

Description

The attached patch updates Rails environment files (development.rb, production.rb, and test.rb in config/environments directory) for Rails 6.1.

By updating the files, several useful new features in Rails 6.1 will be available (e.g. request_id in production.log, verbose_query_logs in development.log). Also, by looking at the commented out settings, the user can easily know what settings are available (e.g. config.force_ssl in config/environments/production.rb).


Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading Closed

Associated revisions

Revision 21343
Added by Go MAEDA 6 months ago

RuboCop: Disable Rails/FilePath and Style/GlobalStdStream (#35081).

Revision 21344
Added by Go MAEDA 6 months ago

Update config/environments/*.rb for Rails 6.1 (#35081).

History

#1 Updated by Go MAEDA about 1 year ago

  • Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added

#2 Updated by Marius BALTEANU about 1 year ago

  • Assignee set to Marius BALTEANU

#3 Updated by Marius BALTEANU 12 months ago

  • Assignee deleted (Marius BALTEANU)
The patch adds two settings in config/environments/production.rb which are already defined in config/application.rb with the same value:

Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling config.assets.css_compressor = :sass it will break Redmine (at least in my local environment).

#4 Updated by Go MAEDA 6 months ago

Marius BALTEANU wrote:

The patch adds two settings in config/environments/production.rb which are already defined in config/application.rb with the same value:

Fixed.

Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling config.assets.css_compressor = :sass it will break Redmine (at least in my local environment).

I checked through configs in the files and removed config.assets.* in config/environments/development.rb and config/environments/production.rb.

Thank you for reviewing the patch.

#5 Updated by Go MAEDA 6 months ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

#6 Updated by Go MAEDA 6 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patches.

Also available in: Atom PDF