Patch #35081: Update config/environments/*.rb for Rails 6.1 - Redmine

Actions

Copy link

Patch #35081

closed

Update config/environments/*.rb for Rails 6.1

Added by Go MAEDA over 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Rails support

Target version:

5.0.0

Start date:

Due date:

% Done:

Estimated time:

Description

The attached patch updates Rails environment files (development.rb, production.rb, and test.rb in config/environments directory) for Rails 6.1.

By updating the files, several useful new features in Rails 6.1 will be available (e.g. request_id in production.log, verbose_query_logs in development.log). Also, by looking at the commented out settings, the user can easily know what settings are available (e.g. config.force_ssl in config/environments/production.rb).

Files

Download all files

0001-RuboCop-Disable-Style-GlobalStdStream-and-Rails-File.patch (949 Bytes) 0001-RuboCop-Disable-Style-GlobalStdStream-and-Rails-File.patch		Go MAEDA, 2021-04-13 04:20
0002-Update-config-environments-.rb-for-Rails-6.1.patch (12.5 KB) 0002-Update-config-environments-.rb-for-Rails-6.1.patch		Go MAEDA, 2021-04-13 04:21
0001-RuboCop-Disable-Style-GlobalStdStream-and-Rails-File.patch (845 Bytes) 0001-RuboCop-Disable-Style-GlobalStdStream-and-Rails-File.patch		Go MAEDA, 2021-12-30 03:42
0002-Update-config-environments-.rb-for-Rails-6.1.patch (11.6 KB) 0002-Update-config-environments-.rb-for-Rails-6.1.patch		Go MAEDA, 2021-12-30 03:42

Related issues

Actions

Copy link

Updated by Go MAEDA over 3 years ago

Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added

Actions

Copy link

Updated by Marius BĂLTEANU over 3 years ago

Assignee set to Marius BĂLTEANU

Actions

Copy link

Updated by Marius BĂLTEANU over 3 years ago

Assignee deleted (~~Marius BĂLTEANU~~)

The patch adds two settings in config/environments/production.rb which are already defined in config/application.rb with the same value:

config.log_level = :info already defined in source:/trunk/config/application.rb#L77
config.i18n.fallbacks = true already defined in source:/trunk/config/application.rb#L57

Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling config.assets.css_compressor = :sass it will break Redmine (at least in my local environment).

Actions

Copy link

Updated by Go MAEDA almost 3 years ago

Marius BALTEANU wrote:

The patch adds two settings in config/environments/production.rb which are already defined in config/application.rb with the same value:

config.log_level = :info already defined in source:/trunk/config/application.rb#L77

config.i18n.fallbacks = true already defined in source:/trunk/config/application.rb#L57

Fixed.

Also, even commented, I don't think that we should settings add which are not working in the current context, for example, enabling config.assets.css_compressor = :sass it will break Redmine (at least in my local environment).

I checked through configs in the files and removed config.assets.* in config/environments/development.rb and config/environments/production.rb.

Thank you for reviewing the patch.

Actions

Copy link