Project

General

Profile

Actions
Copy link

Patch #35610

closed

Cleanups after Wiki tab removal from project settings (#26579)

Added by Marius BĂLTEANU almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Code cleanup/refactoring
Target version:
5.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This is extracted from #34643.

  • 1. Remove 'edit' action from :manage_wiki permission definition in Redmine::AccessControl.
    Wikis#edit is removed by r17018.
  • 2. Redirect_to project_path after WikisController#destroy.
    • Project settings 'wiki' tab is removed by r16917 & r17017.
    • This action is executed outside the project settings scope after r16916, thus we can better redirect to project_path.
  • 3. Set :wiki menu_item for WikisController#destroy.
    This action is executed inside the project wiki scope after r16916, thus we can better set the menu_item accordingly.

Files

Download all files
0001-Remove-edit-action-from-manage_wiki-permission-defin.patch (1.04 KB) 0001-Remove-edit-action-from-manage_wiki-permission-defin.patch Mischa The Evil, 2021-01-27 09:59
0002-Redirect_to-project_path-after-WikisController-destr.patch (1.69 KB) 0002-Redirect_to-project_path-after-WikisController-destr.patch Mischa The Evil, 2021-01-27 09:59
0003-Set-wiki-menu_item-for-WikisController-destroy.patch (939 Bytes) 0003-Set-wiki-menu_item-for-WikisController-destroy.patch Mischa The Evil, 2021-01-27 09:59

Related issues

Copied from Redmine - Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579)Closed

Actions
Actions
Copy link
 #1

Updated by Marius BĂLTEANU almost 3 years ago

  • Copied from Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579) added
Actions
Copy link
 #2

Updated by Marius BĂLTEANU almost 3 years ago

  • File deleted (0004-Disable-the-wiki-module-after-deletion-of-a-project-.patch)
Actions
Copy link
 #3

Updated by Marius BĂLTEANU almost 3 years ago

  • File deleted (0005-Changed-wiki-start_page-name-to-I18n-ed-field_start_.patch)
Actions
Copy link
 #4

Updated by Marius BĂLTEANU almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Marius BĂLTEANU almost 3 years ago

  • Status changed from New to Closed

Patches committed, thank you.

Actions
Copy link
 #6

Updated by Mischa The Evil over 2 years ago

  • Status changed from Closed to Reopened

Thanks for handling this. Now that I've had a second look at this though, I noticed that the remaining 'edit' JavaScript view (source:/trunk/app/views/wikis/edit.js.erb) is obsolete too and that it can be removed. Can this be handled via this issue (without a patch from me) too?

Actions
Copy link
 #7

Updated by Marius BĂLTEANU over 2 years ago

  • Status changed from Reopened to Closed

Mischa The Evil wrote:

Thanks for handling this. Now that I've had a second look at this though, I noticed that the remaining 'edit' JavaScript view (source:/trunk/app/views/wikis/edit.js.erb) is obsolete too and that it can be removed. Can this be handled via this issue (without a patch from me) too?

View removed in r21105, thanks.

Actions
Copy link

Also available in: Atom PDF