Patch #35610
closed
Cleanups after Wiki tab removal from project settings (#26579)
Added by Marius BĂLTEANU almost 3 years ago.
Updated almost 3 years ago.
Category:
Code cleanup/refactoring
Description
This is extracted from #34643.
- 1. Remove '
edit' action from :manage_wiki permission definition in Redmine::AccessControl.
Wikis#edit is removed by r17018.
- 2. Redirect_to
project_path after WikisController#destroy.
- Project settings 'wiki' tab is removed by r16917 & r17017.
- This action is executed outside the project settings scope after r16916, thus we can better redirect to
project_path.
- 3. Set
:wiki menu_item for WikisController#destroy.
This action is executed inside the project wiki scope after r16916, thus we can better set the menu_item accordingly.
Files
- Copied from Patch #34643: Cleanups and fixes after Wiki tab removal from project settings (#26579) added
- File deleted (
0004-Disable-the-wiki-module-after-deletion-of-a-project-.patch)
- File deleted (
0005-Changed-wiki-start_page-name-to-I18n-ed-field_start_.patch)
- Description updated (diff)
- Status changed from New to Closed
Patches committed, thank you.
- Status changed from Closed to Reopened
Thanks for handling this. Now that I've had a second look at this though, I noticed that the remaining 'edit' JavaScript view (source:/trunk/app/views/wikis/edit.js.erb) is obsolete too and that it can be removed. Can this be handled via this issue (without a patch from me) too?
- Status changed from Reopened to Closed
Mischa The Evil wrote:
Thanks for handling this. Now that I've had a second look at this though, I noticed that the remaining 'edit' JavaScript view (source:/trunk/app/views/wikis/edit.js.erb) is obsolete too and that it can be removed. Can this be handled via this issue (without a patch from me) too?
View removed in r21105, thanks.
Also available in: Atom
PDF
Updated by 
Updated by