Mailer.with_synched_deliveries doesn't correctly detect other async Queue adapters
Mailer.with_synched_deliveries source:/trunk/app/models/mailer.rb@21350#L639 will not detect other async queue adapters than the Rails core
ActiveJob::QueueAdapters::AsyncAdapter (such as those used by external queuing systems such as the
With these queue adapters in normal use,
Mailer.with_synched_deliveries does nothing. This can lead to problems as it is expected that email deliveries (in our case daily reminders) would run inline but instead they were attempted to be scheduled using the normal queue adapter.
Updated by Felix Schäfer almost 2 years ago
- File 36393-synched_deliveries_always_inline.patch 36393-synched_deliveries_always_inline.patch added
The attached patch simply removes the check for the
ActiveJob::QueueAdapters::AsyncAdapter. This ensures deliveries in this context are always inline without trying to be clever about it.