Project

General

Profile

Actions

Defect #36394

closed

Avoid passing ActionController::Parameters outside of MailHandlerController

Added by Felix Schäfer about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Currently the MailHandlerController passes an instance of ActionController::Parameters to the MailHandler. The options holds a duplicate ActionController::Parameters of the Controller params.

This can cause difficulties in later processing. We propose explicitly permit-ing the params that will be used later and using a Hash for the options.


Files

Actions #1

Updated by Felix Schäfer about 2 years ago

I have forgotten to add a link to the source code source:/trunk/app/controllers/mail_handler_controller.rb@21350#L31

Actions #2

Updated by Felix Schäfer about 2 years ago

The attached patch allows all options set by rdm-mailhandler.rb source:/trunk/extra/mail_handler/rdm-mailhandler.rb@21350#L156. This will need to be kept in sync, so maybe adding a comment on both sides will make it easier to remember to add new options to the other side too.

Actions #3

Updated by Go MAEDA about 2 years ago

Felix Schäfer wrote:

The attached patch allows all options set by rdm-mailhandler.rb source:/trunk/extra/mail_handler/rdm-mailhandler.rb@21350#L156. This will need to be kept in sync, so maybe adding a comment on both sides will make it easier to remember to add new options to the other side too.

Updated the patch to add a comment on app/controllers/mail_handler_controller.rb and extra/mail_handler/rdm-mailhandler.rb.

Actions #4

Updated by Go MAEDA about 2 years ago

  • Category changed from Email receiving to Code cleanup/refactoring
  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

Actions #5

Updated by Marius BĂLTEANU about 2 years ago

  • Status changed from New to Resolved
  • Assignee set to Marius BĂLTEANU
  • Resolution set to Fixed

Patch committed, thanks!

Actions #6

Updated by Marius BĂLTEANU about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF