Defect #36394
closed
Avoid passing ActionController::Parameters outside of MailHandlerController
0%
Description
Currently the MailHandlerController passes an instance of ActionController::Parameters to the MailHandler. The options holds a duplicate ActionController::Parameters of the Controller params.
This can cause difficulties in later processing. We propose explicitly permit-ing the params that will be used later and using a Hash for the options.
Files
Updated by Felix Schäfer almost 3 years ago
I have forgotten to add a link to the source code source:/trunk/app/controllers/mail_handler_controller.rb@21350#L31
Updated by Felix Schäfer almost 3 years ago
- File 36394-mail_handler_controller_permit_parameters.patch 36394-mail_handler_controller_permit_parameters.patch added
The attached patch allows all options set by rdm-mailhandler.rb source:/trunk/extra/mail_handler/rdm-mailhandler.rb@21350#L156. This will need to be kept in sync, so maybe adding a comment on both sides will make it easier to remember to add new options to the other side too.
Updated by Go MAEDA almost 3 years ago
- File 36394-mail_handler_controller_permit_parameters-v2.patch 36394-mail_handler_controller_permit_parameters-v2.patch added
- Target version set to Candidate for next major release
Felix Schäfer wrote:
The attached patch allows all options set by
rdm-mailhandler.rbsource:/trunk/extra/mail_handler/rdm-mailhandler.rb@21350#L156. This will need to be kept in sync, so maybe adding a comment on both sides will make it easier to remember to add new options to the other side too.
Updated the patch to add a comment on app/controllers/mail_handler_controller.rb and extra/mail_handler/rdm-mailhandler.rb.
Updated by Go MAEDA almost 3 years ago
- Category changed from Email receiving to Code cleanup/refactoring
- Target version changed from Candidate for next major release to 5.0.0
Setting the target version to 5.0.0.
Updated by Marius BĂLTEANU almost 3 years ago
- Status changed from New to Resolved
- Assignee set to Marius BĂLTEANU
- Resolution set to Fixed
Patch committed, thanks!
Updated by Marius BĂLTEANU almost 3 years ago
- Status changed from Resolved to Closed