Actions
Defect #36396
closedCustom I18n Pluralization rules are not applied correctly
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Currently custom pluralization rules are not loaded. This is due to the required ::I18n::Backend::Pluralization
module not being loaded in the correct class.
Files
Related issues
Updated by Felix Schäfer almost 3 years ago
- File 36396-apply_custom_pluralization_rules.patch 36396-apply_custom_pluralization_rules.patch added
The attached Patch changes the inclusion of ::I18n::Backend::Pluralization
to the correct class.
Updated by Go MAEDA almost 3 years ago
- Related to Defect #21856: I18n backend does not support original i18n Pluralization added
Updated by Go MAEDA almost 3 years ago
Felix, do you think the following code I wrote properly tests the issue?
diff --git a/test/unit/lib/redmine/i18n_test.rb b/test/unit/lib/redmine/i18n_test.rb
index 4856c5190..8d076a385 100644
--- a/test/unit/lib/redmine/i18n_test.rb
+++ b/test/unit/lib/redmine/i18n_test.rb
@@ -255,4 +255,13 @@ class Redmine::I18nTest < ActiveSupport::TestCase
set_language_if_valid 'fr'
assert_equal 'French (Français)', l(:general_lang_name)
end
+
+ def test_custom_pluralization_rules
+ I18n.backend.store_translations :en, i18n: {plural: {rule: ->(n) {[0, 1].include?(n) ? :one : :other }}}
+ I18n.backend.store_translations :en, apples: {one: 'one or none', other: 'more than one'}
+ assert_equal 'one or none', ll(:en, :apples, count: 0)
+ assert_equal 'more than one', ll(:en, :apples, count: 2)
+ ensure
+ I18n.reload!
+ end
end
Updated by Go MAEDA almost 3 years ago
- Category changed from Translations to I18n
Updated by Felix Schäfer almost 3 years ago
Go MAEDA wrote:
Felix, do you think the following code I wrote properly tests the issue?
Thank you very much for the suggestion. The proposed test should catch a misconfiguration of the `::I18n::Backend::Pluralization` backend in `::Redmine::I18n`.
Updated by Go MAEDA almost 3 years ago
- Target version set to 4.1.6
Setting the target version to 4.1.6.
Updated by Go MAEDA almost 3 years ago
- Status changed from New to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix. Thank you.
Updated by Go MAEDA almost 3 years ago
- Related to Defect #36461: I18nTest#test_custom_pluralization_rules randomly fails added
Updated by Go MAEDA almost 3 years ago
- Status changed from Resolved to Closed
- Target version changed from 4.1.6 to 5.0.0
Actions