Project

General

Profile

Actions

Defect #36561

closed

Wiki revision page does not return 404 if revision does not exist

Added by . ¦3<RELATIVISM . almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Wiki
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

BUG discovered in wiki revision paths

So like this page only has one revision https://redmine.replicant.us/projects/replicant-infrastructure/wiki/FilteringSpamOnTheMailingList/1
but https://redmine.replicant.us/projects/replicant-infrastructure/wiki/FilteringSpamOnTheMailingList/73 still loads

this can be done with all articles revision pages not just this one.

It is not possible with negative numbers though


Files

defect-36561.patch (1.94 KB) defect-36561.patch Mizuki ISHIKAWA, 2022-02-14 09:01
Actions #1

Updated by Marius BĂLTEANU almost 3 years ago

  • Status changed from New to Confirmed
Actions #2

Updated by Holger Just almost 3 years ago

  • Subject changed from BUG with revision urls to Bug with revision URLs of wiki pages
Actions #3

Updated by Mizuki ISHIKAWA almost 3 years ago

I attached a patch to return 404 when a non-existent revision number is specified.

404: The page you were trying to access doesn't exist or has been removed.

Actions #4

Updated by . ¦3<RELATIVISM . almost 3 years ago

that is great thanks! I will test in our instance if possible

Actions #5

Updated by Marius BĂLTEANU almost 3 years ago

  • Assignee set to Marius BĂLTEANU
  • Target version set to 4.1.6
Actions #6

Updated by Marius BĂLTEANU almost 3 years ago

  • Status changed from Confirmed to Resolved
  • Resolution set to Fixed

Fix committed, thanks!

Actions #7

Updated by Marius BĂLTEANU almost 3 years ago

  • Subject changed from Bug with revision URLs of wiki pages to Wiki revision page does not return 404 if revision does not exist
  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF