Project

General

Profile

Actions
Copy link

Defect #36901

closed

Jump to project is misaligned in Safari 15.4 and later

Added by Vitaly vit9696 over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
UI
Target version:
4.2.8
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
4.2.5

Description

Jump to project dropdown item is misaligned from the project filter field by 1 pixel down as shown on the screenshot. Tested on Safari 15.4 (17613.1.17.1.13).

Files

Download all files
Screenshot 2022-04-06 at 15.09.20.png (9.35 KB) Screenshot 2022-04-06 at 15.09.20.png Vitaly vit9696, 2022-04-06 14:11
36901.patch (2.21 KB) 36901.patch Go MAEDA, 2022-04-16 05:46
Screenshot 2022-04-21 at 21.40.28.png (10.2 KB) Screenshot 2022-04-21 at 21.40.28.png Vitaly vit9696, 2022-04-21 20:41
quick-search.diff (785 Bytes) quick-search.diff Vitaly vit9696, 2022-04-30 13:41
Actions
Copy link
 #1

Updated by Go MAEDA over 2 years ago

  • Subject changed from Jump to project is misaligned to Jump to project is misaligned in Safari 15.4
  • Status changed from New to Confirmed
  • Affected version changed from 5.0.0 to 4.2.5

I have confirmed the issue after updating Safari from 15.3 to 15.4.

Actions
Copy link
 #2

Updated by Mizuki ISHIKAWA over 2 years ago

Adding the following CSS seems to fix it.

#quick-search form { display: inline-block; }
Actions
Copy link
 #3

Updated by Go MAEDA over 2 years ago

  • Target version set to 4.2.6

Setting the target version to 4.2.6.

Actions
Copy link
 #4

Updated by Go MAEDA over 2 years ago

Actions
Copy link
 #5

Updated by Vitaly vit9696 over 2 years ago

This fix is not sufficient, as it results in the dropdown item moving 1 pixel upwards after a click.

Actions
Copy link
 #6

Updated by Vitaly vit9696 over 2 years ago

The attached change looks good to me so far with redmine 5.0.0 on Safari 15.4, Firefox 99.0.1, Chromium 100.0.4896.127.

Actions
Copy link
 #7

Updated by Marius BĂLTEANU over 2 years ago

  • Target version changed from 4.2.6 to 4.2.7
Actions
Copy link
 #8

Updated by Vitaly vit9696 over 2 years ago

Marius, could you please clarify why the attached fix was not committed? Thanks!

Actions
Copy link
 #9

Updated by Marius BĂLTEANU over 2 years ago

Vitaly vit9696 wrote:

Marius, could you please clarify why the attached fix was not committed? Thanks!

The patch was not tested by me or other Redmine maintainer and it was more important to release the new versions because of the security issues. We will do our best to include the fixes in 4.2.7.

Actions
Copy link
 #10

Updated by Vitaly vit9696 over 2 years ago

Sure (y)

Actions
Copy link
 #11

Updated by Marius BĂLTEANU over 2 years ago

  • Target version changed from 4.2.7 to 4.2.8
Actions
Copy link
 #12

Updated by Vitaly vit9696 over 2 years ago

Gentle ping.

Actions
Copy link
 #13

Updated by Vitaly vit9696 over 2 years ago

Hello, Go MAEDA, could you please test the attached patch and commit it if it works for you?
Your attention is also needed on this patch, which would be great to merge into 5.0.3 as well.
Thanks!

Actions
Copy link
 #14

Updated by Go MAEDA about 2 years ago

  • Subject changed from Jump to project is misaligned in Safari 15.4 to Jump to project is misaligned in Safari 15.4 and later
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for reporting and fixing the issue.

Actions
Copy link

Also available in: Atom PDF