Redmine

Setting the target version to 5.1.0.

Added a test to the patch.

This effectively changes EmailAddress::EMAIL_REGEXP from:

/\A([^@\s]+)@((?:[-a-z0-9]+\.)+(?:(?:xn--[-a-z0-9]+)|(?:[a-z]{2,})))\z/i

/\A[a-zA-Z0-9.!\#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*\z/

/^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*$/

• it fixes the cases of the first two email address examples, but $test@example.com still matches (and a little search will probably give more edge-cases);
• the current custom regex includes capture groups while URI::MailTo::EMAIL_REGEXP doesn't (which changes the return value in some cases and thus may break plugins that depend on the current value of EmailAddress::EMAIL_REGEXP) e.g.:
  

  'test@example.com'.match(EmailAddress::EMAIL_REGEXP)
  => #<MatchData "test@example.com" 1:"test" 2:"example.com">
  
  'test@example.com'.match(URI::MailTo::EMAIL_REGEXP)
  => #<MatchData "test@example.com">
  

• given the previous note, this might be something that should be shipped in a major release (6.0.0) instead of a minor release (5.1.0).

¹ https://github.com/ruby/ruby/blob/master/lib/uri/mailto.rb#L54

Committed the patch in r22332.