Actions
Feature #37119
closed
Drop redcarpet dependency for common_mark formatter
Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Description
Redmine fails to start when it's installed without markdown group (#36892).
We should fix this and drop the redcarpet dependency for common_mark.
Files
Related issues
Updated by Marius BĂLTEANU over 2 years ago
- File 0001-Move-methods-related-to-section-to-a-helper-file-and.patch 0001-Move-methods-related-to-section-to-a-helper-file-and.patch added
- File 0002-Drop-redcarpet-dependency-from-common_mark-group.patch 0002-Drop-redcarpet-dependency-from-common_mark-group.patch added
holger mareck, I made a patch that should fix this.
What I did?- I've moved the methods
get_section,update_sectionandextract_sectionsto a new helper file (Redmine::WikiFormatting::SectionHelper) - the new helper file is included by all three formatters
- textile formatter overrides
extract_sectionsmethod which his own implementation - I've removed the
redcarpetdependency fromcommon_markgroup.
What do you think?
Updated by Marius BĂLTEANU over 2 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Thanks Holger for your review. I've committed both changes.
Updated by Holger Just over 1 year ago
- Related to Defect #36892: Redmine does not start when installed --without markdown added
Actions