Feature #37169: Update sanitization rules to allow footnotes markup to match the original structure - Redmine

Actions

Copy link

Feature #37169

open

Update sanitization rules to allow footnotes markup to match the original structure

Added by Marius BĂLTEANU almost 3 years ago. Updated 6 months ago.

Status:

New

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Text formatting

Target version:

6.1.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Description

This is related to #35892.

The sanitisation rules should allow footnotes markup to render as they are generated by commonmark gem for easier customisations.

Files

footnotes.png (232 KB) footnotes.png

Marius BĂLTEANU, 2022-05-31 08:32

Actions

Copy link

Updated by Holger Just almost 3 years ago

Is this resolved with r21612 already or are there any further required steps?

Actions

Copy link

Updated by Marius BĂLTEANU almost 3 years ago

File footnotes.png footnotes.png added

This is how it looks without SanitizationFilter:

And I think it is useful to have the data-footnote-* attributes, the class and even the section element. I've already some working code to obtain this.

What do you think?

Actions

Copy link

Updated by Holger Just almost 3 years ago

I'm not opposed to this :)

I'm not sure the data attributes are required for us, given that we don't have anything in Redmine which wants this (specifically: no browser JS leveraging those attributes).

The aria-label and class attributes are probably useful though, as might be the section.

Actions

Copy link