Project

General

Profile

Actions

Feature #37169

open

Update sanitization rules to allow footnotes markup to match the original structure

Added by Marius BĂLTEANU over 1 year ago. Updated 5 months ago.

Status:
New
Priority:
Normal
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

This is related to #35892.

The sanitisation rules should allow footnotes markup to render as they are generated by commonmark gem for easier customisations.


Files

footnotes.png (232 KB) footnotes.png Marius BĂLTEANU, 2022-05-31 08:32
Actions #1

Updated by Holger Just over 1 year ago

Is this resolved with r21612 already or are there any further required steps?

Actions #2

Updated by Marius BĂLTEANU over 1 year ago

This is how it looks without SanitizationFilter:

And I think it is useful to have the data-footnote-* attributes, the class and even the section element. I've already some working code to obtain this.

What do you think?

Actions #3

Updated by Holger Just over 1 year ago

I'm not opposed to this :)

I'm not sure the data attributes are required for us, given that we don't have anything in Redmine which wants this (specifically: no browser JS leveraging those attributes).

The aria-label and class attributes are probably useful though, as might be the section.

Actions #4

Updated by Go MAEDA 5 months ago

  • Target version changed from 5.1.0 to 6.0.0
Actions

Also available in: Atom PDF