Patch #37867

Limit puma < 6.0.0 to avoid system test error

Added by Ko Nagase about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gems support
Target version:4.2.9

Description

Recently, system test fails with the following error.

% bundle exec rails test:system
Run options: --seed 40281

# Running:

#<Thread:0x000000011134ded0 /Users/sanak/Build/rb/redmine/vendor/bundle/ruby/3.1.0/gems/capybara-3.36.0/lib/capybara/server.rb:76 run> terminated with exception (report_on_exception is true):
/Users/sanak/Build/rb/redmine/vendor/bundle/ruby/3.1.0/gems/capybara-3.36.0/lib/capybara/registrations/servers.rb:32:in `block in <top (required)>': undefined method `stdio' for Puma::Events:Class (NoMethodError)

  events = conf.options[:Silent] ? ::Puma::Events.strings : ::Puma::Events.stdio
                                                                          ^^^^^^
    from /Users/sanak/Build/rb/redmine/vendor/bundle/ruby/3.1.0/gems/capybara-3.36.0/lib/capybara/config.rb:64:in `block in server='
    from /Users/sanak/Build/rb/redmine/vendor/bundle/ruby/3.1.0/gems/capybara-3.36.0/lib/capybara/server.rb:77:in `block in boot'

From the following links,

limiting puma < 6.0.0 seems to be better, because capybara version is specified in Gemfile.

I upload a simple patch to limit puma < 6.0.0, so reviewing it is helpful.

0001-Limit-puma-less-than-6_0_0.patch Magnifier (410 Bytes) Ko Nagase, 2022-10-31 02:02

Associated revisions

Revision 21934
Added by Go MAEDA about 1 month ago

Limit puma < 6.0.0 to avoid system test error (#37867).

Patch by Ko Nagase.

Revision 21935
Added by Go MAEDA about 1 month ago

Merged r21934 from trunk to 5.0-stable (#37867).

Revision 21936
Added by Go MAEDA about 1 month ago

Merged r21934 from trunk to 4.2-stable (#37867).

History

#1 Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version set to 4.2.9

Committed the patch.

Thank you for reporting and fixing the issue.

Also available in: Atom PDF