Redmine

Attached is a completed version of the patch.

Updated the patch:

• Renamed "changed from" to "used to be". It makes it clear that the field has been the value in the past but is different now
• Reordered filters. "has * been" comes first, "used to be" comes after. This is because The "has ever been" operator behaves more like the "is" operator than the "used to be" operator ("has ever been" includes the results of "is", but "used to be" does not. "is" + "used to be" = "has ever been")

Updated the patch again. Renamed "has ever been" to "has been".

Updated the patch. Renamed "used to be" to "was". This is because the operator may select issues that its current value is the specified one.

For example, suppose that the original author of issue 1 is "Dave Lopper" and the author was changed to another person and then changed back to "Dave Lopper". In this case, the "was" (formerly named "used to be") operator selects issues where the current assignee is "Dave Lopper". The sentence "Assignee used to be Dave Lopper" does not make sense in this case.

This is (probably) the final patch. Operator names are "has been", "has never been", and "changed from".

Setting the target version to 5.1.0.

Committed the patch in r22240.

With this change, three new operators "has been", "has never been", and "changed from" that search histories of issues are available for the following filters:

• Tracker
• Priority
• Assignee
• Target version
• Category

The operators behave as follows:

• "has been" operator: finds issues where the given value is either equal to the current value of the field or it was equal to the value of the field at some point in the past
• "has never been" operator: finds issues where the given value is neither equal to the current value of the field nor it has ever been equal to the value of the field in the past
• "changed from" operator: finds issues where the given value was equal to the value of the field at some point in the past

It does not work with PostgreSQL.

Error:
QueryTest#test_operator_changed_from:
ActiveRecord::StatementInvalid: PG::UndefinedFunction: ERROR:  operator does not exist: text = integer
LINE 1: ...p_key = 'status_id' AND journal_details.old_value IN (2,5)))...
                                                             ^
HINT:  No operator matches the given name and argument type(s). You might need to add explicit type casts.

    test/unit/query_test.rb:146:in `find_issues_with_query'
    test/unit/query_test.rb:818:in `test_operator_changed_from'

rails test test/unit/query_test.rb:800

ChunChang (Nagaharu) Lo wrote in #note-14:

Go MAEDA wrote in #note-12:

Could you clear your browser cache and try again? r22240 also updated source:trunk/public/javascripts/application.js.

Yes. it works after clearing the browser cache.

Thank you for your feedback.