Project

General

Profile

Actions

Patch #39066

closed

Remove set_language_if_valid from MyController

Added by Pavel Rosický about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

diff --git a/app/controllers/my_controller.rb b/app/controllers/my_controller.rb
index 9eaaa90e7..1d0ca617d 100644
--- a/app/controllers/my_controller.rb
+++ b/app/controllers/my_controller.rb
@@ -55,7 +55,6 @@ class MyController < ApplicationController
       @user.pref.safe_attributes = params[:pref]
       if @user.save
         @user.pref.save
-        set_language_if_valid @user.language
         respond_to do |format|
           format.html do
             flash[:notice] = l(:notice_account_updated)

the language is reset after the next redirect, so this is basically a dead code that could be removed

Actions #1

Updated by Go MAEDA about 1 year ago

  • Target version set to 5.1.0

Setting the target version to 5.1.0.

Actions #2

Updated by Go MAEDA about 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions

Also available in: Atom PDF