Defect #39795
closed
Fix improper error highlighting for description field in issue form
Added by Mizuki ISHIKAWA 7 months ago.
Updated 6 months ago.
Description
There is a feature that highlights input fields with a red border when a validation error occurs. An issue was identified with the 'Description' field, set as a mandatory input. When a validation error is triggered in this field, the red border is incorrectly positioned.
![](/attachments/download/31590/clipboard-202312081436-va2fa.png)
This problem does not occur with 'Long text' format custom fields. The notable difference is that the 'Description' field contains a 'span#issue_description_and_toolbar' element, which causes the red border to be displayed around the span tag, unlike in custom fields.
Files
The issue can be resolved by modifying the CSS as follows:
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index b92a34d68..3ef6e6180 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -905,7 +905,7 @@ label.block {
color: #bb0000;
}
-.tabular label.error + * {
+.tabular label.error + *:not(span), .tabular label.error + span div.jstBlock {
border: 1px solid #bb0000;
}
Screen after fixed:
![](/attachments/download/31592/clipboard-202312081438-exxmp.png)
The changes in #note-1 were not completely resolved, so I am attaching the patch again.
- Target version set to 5.0.8
Setting the target version to 5.0.8.
- Subject changed from Description field error highlighting misalignment on validation failure to Fix improper error highlighting for description field in issue form
- Target version changed from 5.0.8 to 6.0.0
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix in r22545. Thank you.
Also available in: Atom
PDF