Actions
Patch #40506
closed
Remove redundant ApplicationHelper inclusions
Description
ApplicationHelper has already been included in ActionView::TestCase. Although some test classes inherit from ActionView::TestCase, they include ApplicationHelper in their own classes again. Therefore, we don't need to include ApplicationHelper in those classes because it is already included.
For example, the ancestry of WikiFormatting::MacrosTest is as follows, and it includes ApplicationHelper in the WikiFormatting::MacrosTest class again.
- WikiFormatting::MacrosTest < Redmine::HelperTest < ActionView::TestCase
Files
Updated by Go MAEDA about 1 year ago
- Target version set to 6.0.0
Setting the target version to 6.0.0.
Updated by Takuya Kodama about 1 year ago
Updated by Go MAEDA about 1 year ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the fix in r22777. Thank you for your contribution.
Updated by Marius BĂLTEANU about 1 year ago
The tests are failing https://www.redmine.org/builds/
Updated by Marius BĂLTEANU about 1 year ago
- Status changed from Closed to Reopened
Updated by Marius BĂLTEANU about 1 year ago
- Status changed from Reopened to Closed
Marius BĂLTEANU wrote in #note-4:
The tests are failing https://www.redmine.org/builds/
It was a random failing test.
Actions