Project

General

Profile

Actions
Copy link

Patch #40506

closed

Remove redundant ApplicationHelper inclusions

Added by Takuya Kodama 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
6.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

ApplicationHelper has already been included in ActionView::TestCase. Although some test classes inherit from ActionView::TestCase, they include ApplicationHelper in their own classes again. Therefore, we don't need to include ApplicationHelper in those classes because it is already included.

For example, the ancestry of WikiFormatting::MacrosTest is as follows, and it includes ApplicationHelper in the WikiFormatting::MacrosTest class again.

  • WikiFormatting::MacrosTest < Redmine::HelperTest < ActionView::TestCase

Files

remove-redundant-application-helper-inclusions-git.diff (5.42 KB) remove-redundant-application-helper-inclusions-git.diff Takuya Kodama, 2024-04-01 07:27
Actions
Copy link
 #1

Updated by Go MAEDA 8 months ago

  • Target version set to 6.0.0

Setting the target version to 6.0.0.

Actions
Copy link
 #2

Updated by Takuya Kodama 8 months ago

Go MAEDA wrote in #note-1:

Setting the target version to 6.0.0.

Thank you for handling it.

Actions
Copy link
 #3

Updated by Go MAEDA 8 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix in r22777. Thank you for your contribution.

Actions
Copy link
 #4

Updated by Marius BĂLTEANU 8 months ago

The tests are failing https://www.redmine.org/builds/

Actions
Copy link
 #5

Updated by Marius BĂLTEANU 8 months ago

  • Status changed from Closed to Reopened
Actions
Copy link
 #6

Updated by Marius BĂLTEANU 7 months ago

  • Status changed from Reopened to Closed

Marius BĂLTEANU wrote in #note-4:

The tests are failing https://www.redmine.org/builds/

It was a random failing test.

Actions
Copy link

Also available in: Atom PDF