Redmine

Takenori TAKAKI wrote in #note-1:

I've created a patch to fix this problem and attach it.
Confirmed it works on the latest trunk.
Minoru Maeda, please review the patch!

Thank you for the patch. I applied the patch you provided to trunk@23170 and confirmed it works as expected.
When copying the project, I was able to confirm that custom field values in the "Text" and "List" formats for versions were also carried over! This is fantastic!

I think it works well as it is, but I noticed two points:

1. Custom fields in the "File" format were not copied.
2. For the "Version" and "User" formats, if there were values that do not exist in the target project, the version itself was not copied.

For the first point, it seems necessary to copy the Attachment record because the container is not matching in Redmine::FieldFormat::AttachmentFormat#set_custom_field_value .
As for the second point, I could only think of the idea of logging it, similar to Project.copy_issues .

Using TAKAKI's patch as a base, I created a response proposal for the points mentioned above, but I still think TAKAKI's original patch is preferable for its simplicity and sufficient functionality.

diff --git a/app/models/project.rb b/app/models/project.rb
index c438be16d..778c4d1cf 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -1120,7 +1120,25 @@ class Project < ApplicationRecord
         attachment.copy(:container => new_version)
       end

+      new_version.custom_field_values = version.custom_field_values.inject({}) do |h, v|
+        if v.custom_field.field_format == 'attachment' && v.value.present?
+          attachment = v.custom_field.cast_value(v.value)
+
+          new_version_attachment = attachment.copy(container: new_version)
+          new_version_attachment.save
+          h[v.custom_field_id] = new_version_attachment.id
+        else
+          h[v.custom_field_id] = v.value
+        end
+
+        h
+      end
+
       self.versions << new_version
+
+      if new_version.new_record?
+        logger&.info("Project#copy_versions: #{new_version.name} could not be copied: #{new_version.errors.full_messages}")
+      end
     end
   end