Redmine

I tested the patch and found that the layout of the Versions settings table is broken. An unnecessary padding is added to the left of the shared version names from other projects.

This issue occurs because the following style is incorrectly applied by the attached patch.
https://github.com/redmine/redmine/blob/1612d85ad808c36d7315c75cad1e4bdfbbb9db62/app/assets/stylesheets/application.css#L431

tr.version td.name:not(.icon-shared) { padding-left: 20px; }

To fix this, the following change resolves the issue:

 tr.version.closed, tr.version.closed a { color: #999; }
-tr.version td.name:not(.icon-shared) { padding-left: 20px; }
+tr.version td.name:not(:has(.icon-shared)) { padding-left: 20px; }
 tr.version td.date, tr.version td.status, tr.version td.sharing { text-align: center; white-space:nowrap; }

However, since the .icon-shared class is no longer needed, I updated the patch to rely on the .shared class applied to <tr class="version shared"> tags instead. I have attached the updated patch as "fix-td-layout-shared-version-padding.diff".

Additionally, I removed the unnecessary .icon-sticky and .icon-locked classes from the forums page, as they are also no longer required. These changes are included in the attached patch.

Below is the corrected Versions settings table after applying the updated patch:

Committed the fix in r23317. Thank you.

Merged the fix into the 6.0-stable branch in r23334.

The position of the links on the forum page was shifted due to the change applied in this issue.
Please apply the following fix:

diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
index 1c9595172..81182b2ce 100644
--- a/app/assets/stylesheets/application.css
+++ b/app/assets/stylesheets/application.css
@@ -422,6 +422,7 @@ tr.message { height: 2.6em; }
 tr.message td.created_on { white-space: nowrap; }
 tr.message td.last_message { font-size: 93%; white-space: nowrap; }
 tr.message.sticky td.subject { font-weight: bold; }
+tr.message:not(.sticky):not(.locked) td.subject { padding-left: 20px; }

 body.avatars-on #replies .message.reply {padding-left: 32px;}
 #replies .reply:target h4.reply-header {background-color:#DDEEFF;}

Before this issue's change	After this issue's change	After applying this fix

Thank you for providing the fix. I reviewed the #note-7 patch and tested the following cases:

• When the sticky icon is present.
• When the lock icon is present.
• When no icons are present.
• When the subject is long (see attached screenshot).

Tested in Chrome, Safari, and Firefox. Everything works as expected.