Project

General

Profile

Actions
Copy link

Defect #41883

closed

Download button in issue comments still uses deprecated raster icon

Added by pasquale [:dedalus] about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
UI
Target version:
6.0.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Affected Redmine 6.0.1

Files

Download all files
Screenshot_20241127-221114~2.png (215 KB) Screenshot_20241127-221114~2.png issue-in-action pasquale [:dedalus], 2024-11-27 22:17
screenshot 2024-11-28 17.19.05.png (37.3 KB) screenshot 2024-11-28 17.19.05.png Mizuki ISHIKAWA, 2024-11-28 09:19
Actions
Copy link
 #1

Updated by Mizuki ISHIKAWA about 2 months ago

I think the following changes will solve the problem:

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index dc5b894e5..b4c87f758 100644
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -618,7 +618,7 @@ module IssuesHelper
         value = link_to_attachment(atta, only_path: options[:only_path])
         if options[:only_path] != false
           value += ' '
-          value += link_to_attachment atta, class: 'icon-only icon-download', title: l(:button_download), download: true
+          value += link_to_attachment atta, class: 'icon-only icon-download', title: l(:button_download), download: true, icon: 'download'
         end
       else
         value = content_tag("i", h(value)) if value

Actions
Copy link
 #2

Updated by Go MAEDA about 2 months ago

  • Status changed from New to Confirmed
  • Target version set to 6.0.2
Actions
Copy link
 #3

Updated by Go MAEDA about 2 months ago

  • Subject changed from download icon in comment is still in old style to Download button in issue comments still uses deprecated raster icon
  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r23323. Thank you.

Actions
Copy link
 #4

Updated by Go MAEDA about 2 months ago

  • Status changed from Resolved to Closed

Merged the fix into the 6.0-stable branch in r23335.

Actions
Copy link

Also available in: Atom PDF