Project

General

Profile

Actions

Patch #42135

closed

Enable GitHub Actions for testing and linting on stable branches

Added by Katsuya HIDAKA 2 months ago. Updated 21 days ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This patch enables GitHub Actions to run on stable branches, executing builds for testing and linting.

While GitHub Actions are currently executed for the master branch, they are not yet enabled for stable branches. In particular, running a complete build, including rubocop and stylelint, for the latest stable branch (6.0-stable) should help prevent mistakes like those in #42088 and contribute to the overall quality of Redmine.

This patch ensures that necessary builds are executed and succeed for the 6.0, 5.1, and 5.0 stable branches.

  • Add GitHub Actions workflows for linting and testing
  • Backport necessary fixes from trunk to ensure linting and testing succeed

The details of the builds for each branch are as follows:

Branch [linters] Rubocop [linters] Stylelint [linters] Audit [tests] Ruby versions
6.0-stable Yes Yes Yes 3.1, 3.2, 3.3
5.1-stable Yes Yes No 3.0, 3.1, 3.2
5.0-stable Yes Yes No 3.0, 3.1

The patches are separated by branch:

  • Patches for the 6.0-stable branch: 000x-6.0-stable-*.patch
  • Patches for the 5.1-stable branch: 000x-5.1-stable-*.patch
  • Patches for the 5.0-stable branch: 000x-5.0-stable-*.patch

Files


Related issues

Related to Redmine - Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroringClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Katsuya HIDAKA 2 months ago

I have confirmed that the builds succeed on each branch.
https://github.com/hidakatsuya/redmine/actions

Additionally, by using the GitHub Actions build results, it will be possible to create a simple build status display like the following.

Displaying this on prominent pages like the top page of the redmine.org Overview or the Continuous_integration page will make it easy for anyone to track the build status.

Actions #2

Updated by Go MAEDA 2 months ago

  • Target version set to Candidate for next minor release
Actions #3

Updated by Go MAEDA 2 months ago

  • Related to Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring added
Actions #4

Updated by Go MAEDA 2 months ago

Thank you for submitting the patch. I would like to commit this patch for stable branches once #30069 is complete.

Actions #5

Updated by Marius BĂLTEANU 21 days ago

  • Status changed from New to Closed
  • Assignee set to Marius BĂLTEANU
  • Target version deleted (Candidate for next minor release)

Merged to 6.0-stable and 5.1-stable branches, 5.0-stable receives only security fixes.

Remove from a version because it will be released as part of #30069.

Actions

Also available in: Atom PDF