Redmine

+1
However technically tough that could sound (since I'm not even a web dev XD), less time consuming = faster, and anything that has a potential to speed up the development and generally make it less stressful, is imho should be welcomed. :)

+1

Yes, it's very time consuming to contribute and also for maintainers to verify existing patches.

If you don't want to move to git which was discussed and rejected many times, please at least enable travis on
https://github.com/redmine/redmine
or make a GitLab account and allow to post patches for contributors.

it's an easy change that will save time to everyone.

Hopefully soon™...

I made two changes:
1. Moved the repository from my namespace to a new one created 'redmine-org'.
2. Changed the visibility to public.

If you consider it shouldn't be public, please let me know. I'm still using it to keep my work and run the tests.

are you about to open it for constributors? in such case all stable branches should be marked as protected.

for me it would be much easier. I'll instantly know about potential conflicts or if tests are green without even setting a local enviroment...

Pavel Rosický wrote:

are you about to open it for constributors? in such case all stable branches should be marked as protected.

for me it would be much easier. I'll instantly know about potential conflicts or if tests are green without even setting a local enviroment...

I'm open only to accept new branches to be pushed in order to have the tests run in GitLab CI. Any merge to stable branches it is useless.

In the meantime, I've added Rubocop checks to the pipeline. Test results here.

Go Maeda, I'm planning to add Postegres as well and after that, it's there any chance to have this file committed? Right now I'm cherry picking a commit for every branch that I want to run tests and it's annoying. Or do you prefer to have Jean-Philippe feedback on this?

In my opinion, the absence of this feature really slows down development. Also, such integration may help other projects that are using gitlab/redmine together. We are using redmine to work with tickets but we also have to use gitlab for CI/CD.

+1 to add .gitlab-ci.yml to redmine svn repository, because it will not affect existence rails code and test results.

• Pull Request: https://github.com/sanak/redmine/pull/2
• Test Result: https://github.com/sanak/redmine/actions

Currently, the CI is failing due to an error when executing apt-get install.

...
E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/g/ghostscript/libgs9-common_9.55.0%7edfsg1-0ubuntu5.9_all.deb  404  Not Found [IP: 52.252.75.106 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

Following the above error message, it seems this issue can be resolved by applying the following modification.

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index d35d57406..7017286d4 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -47,10 +47,9 @@ jobs:
         uses: actions/checkout@v4

       - name: Install package dependencies
-        run: >
-          sudo apt-get install --yes --quiet
-          ghostscript
-          gsfonts
+        run: |
+          sudo apt-get update
+          sudo apt-get install --yes --quiet ghostscript gsfonts

       - name: Allow imagemagick to read PDF files
         run: |

After applying this patch, the CI ran successfully.
https://github.com/hidakatsuya/redmine/actions/runs/11840409772/job/32994163366

I think it will be very useful to have at least the system tests (selenium or playwright) running there.

I agree. In my opinion, to ensure the sustainability of the test code for system tests, it is essential to always run them in CI.

Katsuya HIDAKA wrote in #note-12:

Currently, the CI is failing due to an error when executing apt-get install.

[...]

Following the above error message, it seems this issue can be resolved by applying the following modification.

[...]

After applying this patch, the CI ran successfully.
https://github.com/hidakatsuya/redmine/actions/runs/11840409772/job/32994163366

I have committed the fix in r23270. Thank you.

Thanks Mizuki ISHIKAWA, very nice work, I've committed both patches.

• added autoload test
• added stylelint checks

Should we also add bundle-audit check --update to lints?

Should we also add bundle-audit check --update to lints?

I think that's a great idea! Adding bundle-audit check --update to lints would help ensure dependency security checks are consistently enforced. I've seen other repositories running bundle-audit check --update in their GitHub Actions workflows as well.

bundle exec bundle audit check --update added to lints in r23291.

I've created a patch to add SQLite3 tests to CI: #41969.

Katsuya HIDAKA wrote in #note-22:

I've created a patch to add SQLite3 tests to CI: #41969.

Committed, thanks!