Redmine

Patch which corrects the behavior is attached.

New patch revision against Redmine 1.0.1

Please don't assign issues to people without them telling you to do so explicitly.

Also, your patch has some issues.

• You save projects two times and don't check the second time.
• Patches always have to be against trunk to be accepted.
• You are missing some tests.

New patch which handles the update within the custom_value model is attached. Note that I attempted to use the :touch property within the belongs_to in custom_value, but ran into what may be a bug or undefined behavior for polymorphic fields in ActiveRecord (though did not have time to try and debug activerecord itself). I found a way around it by using a callback and then checking if the parent relation was a project.

If there is a better methodology to address this within Redmine's model, please do suggest so that it can be implemented and submitted for inclusion.

Update updated_on of the class (e.g. Project) that uses 'acts_as_customizable' with the following patch.

diff --git a/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb b/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
index 96fdbf8b6..3703a5e65 100644
--- a/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
+++ b/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
@@ -145,7 +145,9 @@ module Redmine
             end
           end
           self.custom_values = target_custom_values
+          custom_values_changed = custom_values.any?(&:changed?)
           custom_values.each(&:save)
+          touch if persisted? && custom_values_changed
           @custom_field_values_changed = false
           true
         end

Setting the target version to 4.2.0.

Committed the patch. Thank you.

The patch breaks an existing test.

Failure:
IssueTest#test_closed_on_should_be_set_when_closing_an_open_issue [/var/lib/jenkins/workspace/trunk/DATABASE_ADAPTER/postgresql/RUBY_VER/ruby-2.6/test/unit/issue_test.rb:3071]:
No visible difference in the ActiveSupport::TimeWithZone#inspect output.
You should look at the implementation of #== on ActiveSupport::TimeWithZone or its members.
Tue, 11 Feb 2020 04:40:14 UTC +00:00

bin/rails test test/unit/issue_test.rb:3064

Go MAEDA wrote:

The patch breaks an existing test.

[...]

The test passes with the following patch. The saved_changes? method is available in Rails 5.1.0 and later.
https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/attribute_methods/dirty.rb#L170
https://github.com/rails/rails/pull/25337

diff --git a/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb b/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
index 3703a5e65..73b2ae847 100644
--- a/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
+++ b/lib/plugins/acts_as_customizable/lib/acts_as_customizable.rb
@@ -145,9 +145,8 @@ module Redmine
             end
           end
           self.custom_values = target_custom_values
-          custom_values_changed = custom_values.any?(&:changed?)
           custom_values.each(&:save)
-          touch if persisted? && custom_values_changed
+          touch if !saved_changes? && custom_values.any?(&:saved_changes?)
           @custom_field_values_changed = false
           true
         end

Committed the new patch. Thank you.