Redmine

I've been thinking about this aswell. Since the CSS selector :empty needs the element to have no white-space I did a small patch.

I can confirm this misbehaviour. But the applied patch won't fix this.

There still need to be some css enhancement to remove the sidebar display.

But in my opinion it would be better that the whole sidebar div won't be rendered at all if there is nothing to display. What do you think?

I don't think introducing a CSS hack would be a good idea for this. I would prefer that ApplicationHelper#has_content? behaves the right way. It turns out simply delegating to Rails' #content_for? seems to work well, but I'd like to understand why Redmine had hack around it in the first place. I'll dig into that and let you know.

After some research, there's a very good reason redmine has hacked around it: it wasn't present in Rails 1.x and 2.x, it was introduced in 3.0.0.

This part of the code is 5 years old, and not really tested, but I guess the framework does the right thing here, so we should rely on it. Jean-Philippe: can you tell me what you think about the attached patch ? Anything I missed ? Does it need some more tests in your opinion ?

This issue is superseded by #15414, which itself is fixed - like suggested by Jean-Baptiste - in r12310.