Redmine

So every time an http request is made for the repository page, redmine can refresh with the remote svn server only if the time since last refresh is greater than set time. This way, if you are navigating the same page within seconds, it will be seamless.

Hi,
I think that there should be a link like Refresh now! in this case.

Ivan

Even that would be a great add-on. But a refresh now button + a refresh interval is the most ideal solution here.

I can't think of a situation where you would not be better served by simply setting up a post-commit-hook in your repository to run the fetch changesets?

This way the repo is only updated when needed, every time :)

Felix Schäfer
Ignore my github example then. We don't really use git. Most of our projects are still under svn.

Why the need for a post-commit-hook when again, the solution is easily implementable within redmine? It's one less thing to worry about or setup. Besides, telling redmine to fetch the latest changeset is not required until someone is about to click that repository tab.

there would still be calls to the SCM repo each time the page is loaded.

Are you referring to browsing through the repo?

Dayson Pais wrote:

Why the need for a post-commit-hook when again, the solution is easily implementable within redmine? It's one less thing to worry about or setup. Besides, telling redmine to fetch the latest changeset is not required until someone is about to click that repository tab.

You seemed to be looking for an efficient solution, the post-commit hook is as efficient as you will get: the info redmine gets and stores about repositories is incrementally updated and only as needed.

With your scenario, a mid-traffic redmine/project will still get enough visits to the repository tab to trigger redmine to fetch changesets every 5 minutes (oder 10 or whatever you set the interval to), which would be as much as you'd get with the cron solution, so I still don't see the big advantage. You either have the choice of simplicity and utter uptodateness with the fetch changeset on each repository page view at the cost of higher load, you can setup the post-commit solution and have uptodateness without the load at the price of a little bit of setup, or half-way between both with the cron solution.

That said, I didn't say I was against implementing something like that, just that it doesn't make (much) sense to me.

there would still be calls to the SCM repo each time the page is loaded.

Are you referring to browsing through the repo?

I'm referring for example to source:/trunk/lib/redmine/scm/adapters/git_adapter.rb#L87 which gets called once for each and every file or directory shown in the repository browser within redmine each time you visit the corresponding repository page. Mind you, that's the one I remember, it might and probably isn't the only one.

I still don't prefer post commit hooks. Especially on remote server's like assembla, etc creating these hooks are complicated. Why all this when redmine can implement this feature within itself?

It's a substitution or rather a redesign of the way the present feature works. The perceived performance will definitely be more & at the same time having the 'refresh' button is a good tool. Sometimes, the svn list fetch can fail due to any reason, so I can manually refresh in that case.

I don't find this feature to be an overhead or unnecessary. It looks quite part of the system to me.

I don't understand the need of refreshing repositories.
Could you please explain, is Redmine caching repository structure? Why's that? I could not find that info in redmine docs.

Redmine stores some metadata for each changeset (id, commit log and the list of affected files) in the database. Basically, it allows searching the commit logs, displaying changesets in the activity view and displaying commit links (eg. r4000).

That said, the repository browser will always hit the repository to list files.