Patch #7086
open
Added by Dmitry Salashnik almost 14 years ago.
Updated almost 14 years ago.
Description
- not works when svn server use self signed certificate
- No read access file breaks file listing when browsing repository
- fetch not all changesets
Files
I understand the last two modifications of the file, but not the first two ones. Can you explain a bit your patch and, if possible, provide some unit tests with it (not for the certificate part, but the things you mention may be testable).
- Skip
directory ANY ITEM if there is no commit date (usually that that we don't have read access to it).
In my reposity exists not readable files for redmine. without this patch directory listing breaks on this file
# Skip directory if there is no commit date (usually that
# means that we don't have read access to it)
- next if entry['kind'] == 'dir' && commit_date.nil?
+# next if entry['kind'] == 'dir' && commit_date.nil?
+ next if commit_date.nil?
- I don't know why, but sometimes
logentry['msg'] = nil
and redmine crashes on this revision and it not appears into redmine's revisions listing :(
- :message => logentry['msg']['__content__'],
+ :message => (logentry['msg'] ? logentry['msg']['__content__'] : ""),
- Simply debugging code, i want know what happens when crashed :)
- rescue
+ rescue Exception => e
+ logger.error "ERROR: #{ e.message}"
- Allow working with self-signed cert
- str << " --no-auth-cache --non-interactive"
+ str << " --no-auth-cache --non-interactive --trust-server-cert"
Jean-Baptiste Barth wrote:
if possible, provide some unit tests with it (not for the certificate part, but the things you mention may be testable).
I'm sorry, but i'm too newbie in ruby :(
- Related to Defect #18754: empty svn logentry crashes revision batch reading added
Also available in: Atom
PDF