Defect #8770: Misleading 'Back' button on 'My Page' personalization screen - Redmine

Actions

Copy link

Defect #8770

closed

Misleading 'Back' button on 'My Page' personalization screen

Added by Denis Savitskiy over 13 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

My page

Target version:

Start date:

2011-07-08

Due date:

% Done:

Estimated time:

0.10 h

Resolution:

Affected version:

Description

I think, the button 'Back' must be 'Save' and class 'icon icon-cancel' must be 'icon icon-save'.

Files

cancel_my_page_v0.1.diff (6.99 KB) cancel_my_page_v0.1.diff

First Patch

Daniel Felix, 2012-12-15 14:31

Actions

Copy link

Updated by Alex Shulgin over 13 years ago

Denis Savitsky wrote:

I think, the button 'Back' must be 'Save' and class 'icon icon-cancel' must be 'icon icon-save'.

There's no 'Back' button on /my/page. You must be talking about /my/page_layout, and yes it would make sense to change it to read 'Save'.

Actions

Copy link

Updated by Denis Savitskiy over 13 years ago

Like this:

  <div class="contextual">
    ..
    <%= link_to l(:button_save), {:action => 'page'}, :class => 'icon icon-save' %>
  </div>

Actions

Copy link

Updated by Etienne Massip over 13 years ago

Target version set to Candidate for next minor release

Indeed, it makes think of it as a Cancel button actually.

Actions

Copy link

Updated by Etienne Massip over 13 years ago

Subject changed from The button 'Back' on my page to Misleading 'Back' button on 'My Page' personalization screen

There should be two buttons : 'Apply' and 'Cancel'.

Actions

Copy link

Updated by Denis Savitskiy over 12 years ago

Etienne Massip wrote:

There should be two buttons : 'Apply' and 'Cancel'.

Is it implemented?

Actions

Copy link

Updated by Tobias Fischer almost 12 years ago

Denis Savitsky wrote:

Is it implemented?

Not yet.
But +1 on this issue!

Actions

Copy link

Updated by Daniel Felix almost 12 years ago

Alex Shulgin wrote:

There's no 'Back' button on /my/page. You must be talking about /my/page_layout, and yes it would make sense to change it to read 'Save'.

Hi,

well I don't think, that it makes much sense to change this to save and/or cancel.

I checked the code, and there is no save action behind this button. My Page is automatically saved on each change (add, delete, order) on a widget. In this context, the back button is pretty right.

Or do you want to have a save/cancel functionality. This means you can change something and still click on cancel and discard your changes?

Best regards,
Daniel

Actions

Copy link

Updated by Daniel Felix almost 12 years ago

File cancel_my_page_v0.1.diff cancel_my_page_v0.1.diff added

Hi there,

I changed my page based on r11000. See attached patched.

I'm not sure if this is the best solution, but I tested it and it worked for me.

The MyPage now supports an edit state and some applied state. You can add some widgets and close it without loosing changes.

Please try it and give some feedback.

Best regards,
Daniel

Actions

Copy link

Updated by Julian S. Luipold almost 12 years ago

Actions

Copy link

#10

Updated by Daniel Felix over 11 years ago

Target version changed from Candidate for next minor release to 2.3.1

This could be also implemented by truncating the latest changes and renaming back to cancel.
Just the truncating of the latest changes could be a little bit tricky as every action currently cause a save.

Actions

Copy link

#11

Updated by Jean-Philippe Lang over 11 years ago

Target version changed from 2.3.1 to Candidate for next major release

I think that the Cancel option is a bit overkill and I don't like storing temporary data in user preferences so much. The cancel option used to exist (layout was stored in session) but it was removed in r3194. I don't know if it's worth restoring it.

Actions

Copy link

#12

Updated by Denis Savitskiy almost 10 years ago

Daniel Felix wrote:

This could be also implemented by truncating the latest changes and renaming back to cancel.
Just the truncating of the latest changes could be a little bit tricky as every action currently cause a save.

It's not worth it, i think. The main idea of this issue was in meaning of "back" button, that it is not clear, what is going to happen. Will the data be saved or not?

Actions

Copy link

#13

Updated by Anonymous over 8 years ago

+1
Several of our users have also complained about the misleading name of the "back" button. "Apply" or simply "OK" / "Done" would be much more fitting.

Actions

Copy link

#14