Defect #9676
closed
Reminder emails also includes overdue issues
Added by Mischa The Evil over 12 years ago.
Updated over 9 years ago.
Description
After I noticed #5058 I finally could test the reminder email feature. First thing I ran into is that also overdue issue are included. This happens with and without the days option. In my case the included overdue issue were due on 31-10-2010.
I already took a quick look at the responsible code in source:/trunk/app/models/mailer.rb but couldn't find anything causing this behavior.
If this is currently the designed behaviour it is ok to me, although then the docs should be updated.
Environment:
- Redmine: source:/trunk@7962
- Ruby: 1.8.7 [x86_64-linux] (REE 1.8.7-2011.03)
- RubyGems: 1.3.7
- Rack: 1.1.2
- Rails: 2.3.14
- MySQL: 5.1.41
- Browser: Mozilla Firefox 7.0.1
Please let me know if more information is required.
Including the overdue issues in the reminder seems fine since they are issues that still need to be fixed?
It looks like an expected behaviour to me.
- Category changed from Email notifications to Documentation
- Assignee set to Mischa The Evil
To be clear: it's fine to me unless this is unexpected behavior. I opened this issue as a defect because:
- RedmineReminderEmails explicitly states: "... about issues due in the next days."
- source:/trunk/app/models/mailer.rb#L346 contains: "
days.day.from_now.to_date
" which made me think that only issues due between from.now
and to_date
were included.
A second look however, showed me that it is a <=
statement which explains the here described behavior. Thus it is expected indeed.
I'll update the available docs.
Same observation here. Behavior does not match documentation.
Also, documentation for this feature matches behavior in Redmine issue queries (that is, in both, "due in 7 days" means "from now till 7 days, not overdue").
The only exception here is behavior of this particular feature.
Thanks in advance for improving consistency.
- Status changed from New to Closed
- Resolution set to Fixed
Also available in: Atom
PDF