Project

General

Profile

Actions

Feature #1069

closed

Open Help in a separate tab

Added by Jon Morrow almost 16 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

The help link in the top menu should launch in a new page. As it currently works if a user clicks this link they are taken to redmine.org. If they then navigate around to find their solution they will have to hit the back button numerous times before they are returned to their project page. I was trying to look into this and provide a patch but do not know ruby at all. I will keep looking into and post said patch if I figure it out. BTW - Great software.


Files

help_menu_in_new_window.txt (837 Bytes) help_menu_in_new_window.txt patch for opening help in a new window Vijay Kiran, 2008-04-24 14:57
1069.patch (1.17 KB) 1069.patch Go MAEDA, 2022-07-11 17:09
1069-v2.patch (1.21 KB) 1069-v2.patch Go MAEDA, 2022-07-12 00:14

Related issues

Related to Redmine - Feature #13263: Prevent confusion generated by the top Help linkClosed

Actions
Actions #1

Updated by Vijay Kiran almost 16 years ago

I'm not sure if this the rightway to do it. But this patch works for me.

Actions #2

Updated by Jon Morrow almost 16 years ago

Will take a look at this later today! Thanks!!!

Actions #3

Updated by Jon Morrow almost 16 years ago

Me like thanks!

Actions #4

Updated by Toshi MARUYAMA over 9 years ago

  • Related to Feature #13263: Prevent confusion generated by the top Help link added
Actions #5

Updated by Go MAEDA over 1 year ago

I think also "Powered by Redmine" link in the footer should open a new tab. Attaching a patch.

Actions #6

Updated by Holger Just over 1 year ago

Just adding target="_blank" potentially allows the target of the link to interact with the original site which opened the link via the window.opener property to e.g. load a new page there, resulting in the thread of phishing, credential stealing or worse.

This can be circumvented by adding rel="noopener" to these links. While most modern browsers now implicitly set this for any such links, some do not yet. As such, it is still a safer option to explicitly set this too. In your patch, you can set this with

... :target => '_blank', rel => 'noopener' ...

See https://mathiasbynens.github.io/rel-noopener/ for a description of the original issue and its workarounds.

Actions #7

Updated by Go MAEDA over 1 year ago

Holger Just wrote:

This can be circumvented by adding rel="noopener" to these links.

Updated the patch. Thank you for pointing it out.

Actions #8

Updated by Holger Just over 1 year ago

Looks good to me!

Actions #9

Updated by Go MAEDA over 1 year ago

  • Target version changed from Candidate for next major release to 5.1.0

Setting the target version to 5.1.0.

Actions #10

Updated by Go MAEDA over 1 year ago

  • Subject changed from "Help" link should launch new page. to Open Help in a separate tab
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Actions #11

Updated by Mischa The Evil 5 months ago

  • Start date deleted (2008-04-15)
Actions

Also available in: Atom PDF