Feature #1069
closed
Open Help in a separate tab
Added by Jon Morrow over 16 years ago.
Updated about 1 year ago.
Description
The help link in the top menu should launch in a new page. As it currently works if a user clicks this link they are taken to redmine.org. If they then navigate around to find their solution they will have to hit the back button numerous times before they are returned to their project page. I was trying to look into this and provide a patch but do not know ruby at all. I will keep looking into and post said patch if I figure it out. BTW - Great software.
Files
I'm not sure if this the rightway to do it. But this patch works for me.
Will take a look at this later today! Thanks!!!
- Related to Feature #13263: Prevent confusion generated by the top Help link added
I think also "Powered by Redmine" link in the footer should open a new tab. Attaching a patch.
Just adding target="_blank" potentially allows the target of the link to interact with the original site which opened the link via the window.opener property to e.g. load a new page there, resulting in the thread of phishing, credential stealing or worse.
This can be circumvented by adding rel="noopener" to these links. While most modern browsers now implicitly set this for any such links, some do not yet. As such, it is still a safer option to explicitly set this too. In your patch, you can set this with
... :target => '_blank', rel => 'noopener' ...
See https://mathiasbynens.github.io/rel-noopener/ for a description of the original issue and its workarounds.
Holger Just wrote:
This can be circumvented by adding rel="noopener" to these links.
Updated the patch. Thank you for pointing it out.
- Target version changed from Candidate for next major release to 5.1.0
Setting the target version to 5.1.0.
- Subject changed from "Help" link should launch new page. to Open Help in a separate tab
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
- Start date deleted (
2008-04-15)
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Toshi MARUYAMA 
Updated by 
Updated by 
Updated by