Project

General

Profile

Actions
Copy link

Feature #13596

closed

Add setting to allow/deny time logging on closed issues

Added by Filou Centrinov over 12 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Time tracking
Target version:
6.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Time logging should be only possible for issues which are open. May an options is added to the time tracking rights for a role.

Files

Download all files
_action_menu.patch (1.12 KB) _action_menu.patch Pavel Potcheptsov, 2013-11-18 10:00
0001-Adds-setting-to-allow-timelog-on-closed-issues.patch (9.02 KB) 0001-Adds-setting-to-allow-timelog-on-closed-issues.patch Marius BĂLTEANU, 2024-12-11 20:58

Related issues

Related to Redmine - Feature #3322: Setting to restrict spent times on future datesClosedGo MAEDA2009-05-08

Actions
Related to Redmine - Feature #13244: Restrict log time for old daysReopened

Actions
Actions
Copy link
 #1

Updated by Filou Centrinov about 12 years ago

Actions
Copy link
 #2

Updated by Pavel Potcheptsov over 11 years ago

This works for me.
Change issue.status_id to number that points to your Closed issues.

Actions
Copy link
 #3

Updated by Toshi MARUYAMA almost 9 years ago

Actions
Copy link
 #4

Updated by Toshi MARUYAMA almost 9 years ago

Actions
Copy link
 #5

Updated by Toshi MARUYAMA almost 9 years ago

Actions
Copy link
 #6

Updated by Toshi MARUYAMA almost 9 years ago

  • Related to Feature #3322: Setting to restrict spent times on future dates added
Actions
Copy link
 #7

Updated by Marius BĂLTEANU 7 months ago

Actions
Copy link
 #8

Updated by Marius BĂLTEANU 7 months ago

  • Assignee set to Marius BĂLTEANU
  • Target version set to 6.1.0

A patch has been posted in #13244.

Actions
Copy link
 #10

Updated by Marius BĂLTEANU 3 months ago

  • Subject changed from Allow time logging only for open issues to Add setting to allow/deny time logging on closed issues
  • Status changed from New to Resolved
  • Resolution set to Fixed

Setting added in r23586, you can now configure the desired behaviour.

Actions
Copy link
 #11

Updated by Marius BĂLTEANU 3 months ago

  • Status changed from Resolved to Closed

All tests pass now.

Actions
Copy link
 #12

Updated by Holger Just 3 months ago

  • Status changed from Closed to Reopened

Thank you Marius.

On doubt though: in the issue.rb patch in r23586, you refer to Setting.timelog_accept_future_dates?. Shouldn't this refer to Setting.timelog_accept_closed_issues? with a different boolean negation instead, i.e.

# Returns true if user or current user is allowed to log time on the issue
def time_loggable?(user=User.current)
  user.allowed_to?(:log_time, project) && (Setting.timelog_accept_closed_issues? || !closed?)
end
Actions
Copy link
 #13

Updated by Marius BĂLTEANU 3 months ago

Holger Just wrote in #note-12:

Thank you Marius.

On doubt though: in the issue.rb patch in r23586, you refer to Setting.timelog_accept_future_dates?. Shouldn't this refer to Setting.timelog_accept_closed_issues? with a different boolean negation instead, i.e.

[...]

Yes, I saw that mistake right after I've committed the change and a test started to failed. The problem is already fixed in r23589.

Actions
Copy link
 #14

Updated by Holger Just 3 months ago

  • Status changed from Reopened to Closed

I see, thanks. Sorry that I missed that.

Actions
Copy link
 #15

Updated by Marius BĂLTEANU 3 months ago

Holger Just wrote in #note-14:

I see, thanks. Sorry that I missed that.

Don't worry, thanks for reviewing the changes!

Actions
Copy link

Also available in: Atom PDF