Feature #13746
closed
Highlighting of source link target line
Added by Filou Centrinov over 11 years ago.
Updated over 11 years ago.
Description
It would be really useful if the target line from a source link is highlighted.
Example:
Source link: source:tags/2.3.0/Gemfile#L3
The 3rd line should be highlighted:
This could be done with pure css. To make the patch complete also app/views/common/_diff.html.erb and app/views/repositories/annotate.html.erb with appropriate css-modifications should be applied.
Files
- Target version set to Candidate for next major release
UPDATE: There is no need to patch also app/views/common/_diff.html.erb or app/views/repositories/annotate.html.erb, because we can't set a link to a line of diff code.
Filou Centrinov wrote:
UPDATE: There is no need to patch also app/views/common/_diff.html.erb or app/views/repositories/annotate.html.erb, because we can't set a link to a line of diff code.
You are right about app/views/common/_diff.html.erb which doesn't have the "clickable line #'s". app/views/repositories/annotate.html.erb on the other hand actually has the same 'line #' representation as app/views/common/_file.html.erb so in that way it would make sense to also apply this patch to this view.
Edit by MTE: of course you are right that we can't link to a line in the annotation view...
Ref: #2835 (r2527).
- Status changed from New to Closed
- Target version changed from Candidate for next major release to 2.4.0
- Resolution set to Fixed
Patch committed in r11858, thanks! I've changed the annotate view for consistency. There's no magic link available we can still link to it manually.
- Has duplicate Feature #6362: Highlight lines via URL in repository browsings file view added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by Toshi MARUYAMA