Project

General

Profile

Actions

Feature #15275

closed

Improve usage of label "button_update"

Added by Björn Peemöller over 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Low
Category:
Translations
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Hi, today I discovered an improper german translation of button_update:

button_update: Bearbeiten

should better be

button_update: Aktualisieren

While the first has the meaning of "edit", the second corresponds to "update by applying my changes". Unfortunately, button_update seems also to be used for editing issues:

$ grep -rn button_update app/
app/views/issues/_action_menu.html.erb:2:<%= link_to l(:button_update), edit_issue_path(@issue), :onclick => 'showAndScrollTo("update", "issue_notes"); return false;', :class => 'icon ico
n-edit', :accesskey => accesskey(:edit) if @issue.editable? %>
app/views/issues/show.html.erb:131:  <h3><%= l(:button_update) %></h3>
app/views/repositories/committers.html.erb:39:<p><%= submit_tag(l(:button_update)) %></p>

Therefore, I would suggest to change the translation and change button_update to button_edit for the first two occurrences. It is fine for the third, I think.

What do you think? Comments welcome!


Related issues

Related to Redmine - Defect #7856: Change "Update" to "Update/Reply" on issue#showClosed2011-03-14

Actions
Related to Redmine - Defect #9033: German semantic translation mistakeClosed2011-08-10

Actions
Actions #1

Updated by Björn Peemöller over 10 years ago

Well, another solution may also be to change button_update to button_save in app/views/repositories/committers.html.erb:39, but I think the other change may also be worth it.

Actions #2

Updated by Jean-Philippe Lang over 10 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 2.5.0
  • Resolution set to Fixed

Changes done.

Actions #3

Updated by Björn Peemöller over 10 years ago

Cool, thanks!

Actions #4

Updated by Stanislav German-Evtushenko almost 10 years ago

And now we have a weird way to add a comment by the "Edit" button. I'm sure we will get used to it but it doesn't seem logical.

Actions #5

Updated by Go MAEDA about 9 years ago

  • Related to Defect #7856: Change "Update" to "Update/Reply" on issue#show added
Actions #6

Updated by Mischa The Evil almost 2 years ago

  • Related to Defect #9033: German semantic translation mistake added
Actions

Also available in: Atom PDF