Redmine

This also happens with 2.5.2.stable and I can confirm that the patch provided by "qu al" works fine.

The UTF8 patch by Jean-Philippe in #13520 (r13807) added in v2.6.1 didn't fix this problem.

It still appears in v2.6.1.stable.13876 and I can confirm that the patch provided by "qu al" still works.

git_adapter.rb.patch cannot be accepted because it hard-code "UTF-8".
Redmine supports any encondings.
It needs more works.

Tobias Fischer wrote:

The UTF8 patch by Jean-Philippe in #13520 (r13807) added in v2.6.1 didn't fix this problem.

It is not related.

Same problem here ...

Processing by RepositoriesController#show as HTML
  Parameters: {"id"=>"development"}
  Current user: jonw (id=4)
  Rendered repositories/_navigation.html.erb (175.1ms)
  Rendered repositories/_breadcrumbs.html.erb (2.8ms)
  Rendered repositories/_dir_list_content.html.erb (170.9ms)
  Rendered repositories/_dir_list.html.erb (172.4ms)
  Rendered repositories/_revision_graph.html.erb (4.9ms)
  Rendered repositories/_revisions.html.erb (207.9ms)
  Rendered repositories/show.html.erb within layouts/base (575.0ms)
Completed 500 Internal Server Error in 5821.6ms

ActionView::Template::Error (incompatible character encodings: UTF-8 and ASCII-8BIT):
    55:         <%= yield :sidebar %>
    56:         <%= view_layouts_base_sidebar_hook_response %>
    57:     </div>
    58:
    59:     <div id="content">
    60:         <%= render_flash_messages %>
    61:         <%= yield %>
  app/views/layouts/base.html.erb:58:in `_app_views_layouts_base_html_erb___4435422814910722795_44338100'
  app/controllers/repositories_controller.rb:125:in `show'

When can we expect this issue to be resolved?

Jonathan Wiens wrote:

When can we expect this issue to be resolved?

git_adapter.rb.patch needs supporting any encoding and tests.

Toshi MARUYAMA wrote:

Jonathan Wiens wrote:

When can we expect this issue to be resolved?

git_adapter.rb.patch needs supporting any encoding and tests.

Can someone do it?

Mercurial test covers non ASCII tag and branch.
source:tags/3.1.1/test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb#L322

Git needs same test.

While the proposed patch might not be 100% correct in all cases, it is still way better than just running into a hard error on rendering.

If you want to be better by detecting and rendering further encodings: fine. But by all means, please support the (at least) 80% case of UTF-8 branch names. For future work, you could repurpose @path_encoding (which defaults to UTF-8).

In fact, it is probably safe enough to just call .force_encoding(@path_encoding) and call it a day. This is most probably safe as git stores the names of tags and branches in the filesystem anyway so the encoding of path names is probably the same as the encoding of the branch names.

Still, please commit one of the fixes. Even it it still breaks on some edge-cases, it is way better than what we have now.

I will give this ticket a bump.

Error occurred in redmine 3.3.3.
Patch from Tobias Fischer worked.

My Environment:

Environment:
  Redmine version                3.3.3.stable
  Ruby version                   2.2.7-p470 (2017-03-28) [x86_64-linux]
  Rails version                  4.2.7.1
  Environment                    production
  Database adapter               Mysql2
SCM:
  Subversion                     1.9.5
  Git                            2.11.0
  Filesystem                     
  GitRemote                      2.11.0
Redmine plugins:
  redmine_git_remote             0.0.1
  scrum                          0.17.0
  ...

So:

Still, please commit one of the fixes. Even it it still breaks on some edge-cases, it is way better than what we have now.

?