Project

General

Profile

Actions
Copy link

Feature #23518

closed

Move action links and edit form above the history when displaying comments in reverse order

Added by Mikhail Varabyou over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
Jean-Philippe Lang
Category:
Issues
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

When we switch comments to reverse chronological order `action_menu` and div#update are still below History section. This requires either scrolling to the top or to the very bottom of the page to be able to click "edit".
Is it possible to move `action_menu` and `edit` partials above div#history for User.current.wants_comments_in_reverse_order? ?

Files

patch_01.patch (1.64 KB) patch_01.patch Mikhail Varabyou, 2016-08-05 12:41

Related issues

Related to Redmine - Patch #12524: Update issue - form positionClosed

Actions
Related to Redmine - Defect #31438: Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological orderClosedGo MAEDA

Actions
Related to Redmine - Patch #32370: Action menu on issues details should not flip with the history orderNew

Actions
Has duplicate Redmine - Feature #7637: Display edit form above History in reverse chronological orderClosed2011-02-16

Actions
Has duplicate Redmine - Feature #26861: Display Issue Edit form Position according to comments chronological orderClosed

Actions
Actions
Copy link
 #1

Updated by Anonymous over 8 years ago

+1
This could be quite a useful addition to also have the buttons available right above the first history entry.

Actions
Copy link
 #2

Updated by Toshi MARUYAMA about 8 years ago

  • Target version set to 3.4.0
Actions
Copy link
 #3

Updated by Go MAEDA over 7 years ago

+1 for this feature.

I usually see comments in reverse chronological order, so I have to scroll up and down frequently when I write comment while referring to recent comments.

Actions
Copy link
 #4

Updated by Jean-Philippe Lang over 7 years ago

  • Target version deleted (3.4.0)

Such a change could have heavy consequences for plugins. We need much more requests for this before changing the issue view in this way.

Actions
Copy link
 #5

Updated by Go MAEDA over 7 years ago

  • Has duplicate Feature #7637: Display edit form above History in reverse chronological order added
Actions
Copy link
 #6

Updated by Yuuki NARA over 7 years ago

+1

I agree with this function.
When editing, since you often see the latest history.
Scrolling the screen long will reduce operability.

Actions
Copy link
 #7

Updated by Toshi MARUYAMA over 7 years ago

  • Related to Patch #12524: Update issue - form position added
Actions
Copy link
 #8

Updated by Go MAEDA about 7 years ago

  • Related to Feature #26861: Display Issue Edit form Position according to comments chronological order added
Actions
Copy link
 #9

Updated by Go MAEDA about 7 years ago

  • Related to deleted (Feature #26861: Display Issue Edit form Position according to comments chronological order)
Actions
Copy link
 #10

Updated by Go MAEDA about 7 years ago

  • Has duplicate Feature #26861: Display Issue Edit form Position according to comments chronological order added
Actions
Copy link
 #11

Updated by Tatsuya Saito about 7 years ago

+1

Actions
Copy link
 #12

Updated by Go MAEDA about 7 years ago

  • Target version set to 4.0.0

Jean-Philippe Lang wrote:

Such a change could have heavy consequences for plugins. We need much more requests for this before changing the issue view in this way.

We will switch to Rails 5.1 in Redmine 4.0 and it will break a large majority of plugins. So I think we don't have to consider about plugins if we deliver this feature in 4.0.0.

I am setting target version again in order to ask Jean-Phillpe Lang for judgment.

Actions
Copy link
 #13

Updated by Bernhard Rohloff about 7 years ago

+1

Actions
Copy link
 #14

Updated by rip heminway almost 7 years ago

+1

Actions
Copy link
 #15

Updated by Jean-Philippe Lang over 6 years ago

  • Subject changed from Display comments in reverse chronological order: position of action_menu and edit partials. to Move action links and edit form above the history when displaying comments in reverse order
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks.

Actions
Copy link
 #16

Updated by Go MAEDA over 5 years ago

  • Related to Defect #31438: Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order added
Actions
Copy link
 #17

Updated by Go MAEDA about 5 years ago

  • Related to Patch #32370: Action menu on issues details should not flip with the history order added
Actions
Copy link

Also available in: Atom PDF