Project

General

Profile

Actions
Copy link

Defect #24309

closed

Setting page for repository does not scroll horizontally on small screens

Added by Dmitry Lisichkin about 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
UI - Responsive
Target version:
3.4.7
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Horizontall scroll bar is missed on settings page for repository.
Problem appears after #20632 (because overflow: hidden; on #wrapper)

We can wrap repositories table with .autoscroll ofcouse or even do it in common/_tabs.html.erb
But maybe it would be better to remove overflow: hidden; from #wrapper?
I dont know what is the best way to fix this and want to discuss because this problem may affect many other pages.
I think that turning off horizontal scroll completely is not a good idea.

Similar problems:
#22336
#21808#note-5

Files

Download all files
scrollbar_missed _-(.png (20.8 KB) scrollbar_missed _-(.png Dmitry Lisichkin, 2016-11-09 16:06
displaying_the_scroll_bar_on_settings_page_for_repository.patch (2.84 KB) displaying_the_scroll_bar_on_settings_page_for_repository.patch Tomomi Yuzuriha, 2018-07-13 08:02

Related issues

Related to Redmine - Patch #22336: Revision Table does not scroll horizontally on small screensClosedJean-Philippe Lang

Actions
Related to Redmine - Defect #28523: Display horizontal scroll bar of plugins table when overflow occurs on small screenClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Toshi MARUYAMA almost 8 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Go MAEDA over 6 years ago

  • Related to Patch #22336: Revision Table does not scroll horizontally on small screens added
Actions
Copy link
 #3

Updated by Go MAEDA over 6 years ago

  • Related to Defect #28523: Display horizontal scroll bar of plugins table when overflow occurs on small screen added
Actions
Copy link
 #4

Updated by Go MAEDA over 6 years ago

  • Category changed from UI to UI - Responsive
  • Target version set to Candidate for next minor release
Actions
Copy link
 #5

Updated by Tomomi Yuzuriha over 6 years ago

I felt it was difficult to judge whether deleting "overflow: hidden; on # wrapper" would be fine or not, Because the range of #wrapper is too big.
So, I propose a patch using the same way as #22336 (displaying the scroll bar using .autoscroll).

Actions
Copy link
 #6

Updated by Go MAEDA over 6 years ago

  • Subject changed from Horizontal scrollbar is missing to Horizontal scrollbar is missing on settings page for repository
  • Target version changed from Candidate for next minor release to 3.4.7

The very similar fixes were already delivered by #22336 and #28523. Setting the target version to 3.4.7.

Actions
Copy link
 #7

Updated by Go MAEDA over 6 years ago

  • Status changed from New to Resolved
Actions
Copy link
 #8

Updated by Go MAEDA over 6 years ago

  • Subject changed from Horizontal scrollbar is missing on settings page for repository to Setting page for repository does not scroll horizontally on small screens
  • Status changed from Resolved to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed. Thank you all for reporting and fixing this issue.

Actions
Copy link

Also available in: Atom PDF